Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Structural refactoring #104

Draft
wants to merge 47 commits into
base: main
Choose a base branch
from
Draft

Structural refactoring #104

wants to merge 47 commits into from

Conversation

lasuillard
Copy link
Owner

@lasuillard lasuillard commented Jan 20, 2025

Lots of backward-incompatible structural changes in overall codebase for extensibility and maintainability of this library.

Changes will be released in 0.3.0 and totally incompatible with previous versions.

  • Rewrite codebase
  • Write tests
  • Update documentation
  • Update examples
  • Update translations

@lasuillard lasuillard added the enhancement New feature or request label Jan 20, 2025
@lasuillard lasuillard self-assigned this Jan 20, 2025
Copy link

codecov bot commented Jan 20, 2025

Codecov Report

Attention: Patch coverage is 95.37037% with 20 lines in your changes missing coverage. Please review.

Project coverage is 97.80%. Comparing base (b2f225a) to head (ea2a7a1).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...o_slack_tools/slack_messages/middlewares/django.py 73.68% 20 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              main     #104      +/-   ##
===========================================
- Coverage   100.00%   97.80%   -2.20%     
===========================================
  Files           31       41      +10     
  Lines          830      911      +81     
  Branches       106       72      -34     
===========================================
+ Hits           830      891      +61     
- Misses           0       20      +20     
Flag Coverage Δ
django-4.2 97.80% <95.37%> (-2.20%) ⬇️
django-5.0 97.80% <95.37%> (-2.20%) ⬇️
django-5.1 97.80% <95.37%> (-2.20%) ⬇️
python-3.10 97.80% <95.37%> (-2.20%) ⬇️
python-3.11 97.80% <95.37%> (-2.20%) ⬇️
python-3.12 97.80% <95.37%> (-2.20%) ⬇️
python-3.13 97.80% <95.37%> (-2.20%) ⬇️
python-3.9 97.79% <95.37%> (-2.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant