dracut: favour systemd units over dracut hooks #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This one stood out in my editor.
In general, when possible it's better to use systemd units instead of dracut hooks because it's (not surprisingly) easier to integrate with other systemd units in the initramfs. Let's do our part towards eventually phasing out the "init system within an init system" situation we're in right now and prefer systemd units on systemd-based initrds. It also mirrors how unlocking works in the real root. You can see this similar "don't ship hooks on systemd" pattern in other dracut modules (for example `04watchdog`, `50plymouth`, and `90crypt`).
martinezjavier
approved these changes
Aug 1, 2020
sergio-correia
approved these changes
Aug 10, 2020
jlebon
added a commit
to jlebon/fedora-coreos-config
that referenced
this pull request
Aug 11, 2020
This implements the rootmap functionality that figures out all the dependencies required to find `/sysroot`, and injects them into the BLS config. For more information, see: coreos/fedora-coreos-tracker#94 (comment) The `rdcore` code supports RAID and LUKS devices, though the latter needs a new Clevis release with the following patches to be fully supported: latchset/clevis#211 latchset/clevis#217 This also implements the `root=UUID=$uuid` inject patch proposed in coreos/fedora-coreos-tracker#465. On its own, this unlocks reprovisioning FCOS with root on a RAID device, or e.g. in-place reprovisioning of root on btrfs. Closes: coreos/fedora-coreos-tracker#465 Closes: coreos/fedora-coreos-tracker#94
jlebon
added a commit
to jlebon/fedora-coreos-config
that referenced
this pull request
Aug 20, 2020
This implements the rootmap functionality that figures out all the dependencies required to find `/sysroot`, and injects them into the BLS config. For more information, see: coreos/fedora-coreos-tracker#94 (comment) The `rdcore` code supports RAID and LUKS devices, though the latter needs a new Clevis release with the following patches to be fully supported: latchset/clevis#211 latchset/clevis#217 This also implements the `root=UUID=$uuid` inject patch proposed in coreos/fedora-coreos-tracker#465. On its own, this unlocks reprovisioning FCOS with root on a RAID device, or e.g. in-place reprovisioning of root on btrfs. Closes: coreos/fedora-coreos-tracker#465 Closes: coreos/fedora-coreos-tracker#94
jlebon
added a commit
to coreos/fedora-coreos-config
that referenced
this pull request
Aug 27, 2020
This implements the rootmap functionality that figures out all the dependencies required to find `/sysroot`, and injects them into the BLS config. For more information, see: coreos/fedora-coreos-tracker#94 (comment) The `rdcore` code supports RAID and LUKS devices, though the latter needs a new Clevis release with the following patches to be fully supported: latchset/clevis#211 latchset/clevis#217 This also implements the `root=UUID=$uuid` inject patch proposed in coreos/fedora-coreos-tracker#465. On its own, this unlocks reprovisioning FCOS with root on a RAID device, or e.g. in-place reprovisioning of root on btrfs. Closes: coreos/fedora-coreos-tracker#465 Closes: coreos/fedora-coreos-tracker#94
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In general, when possible it's better to use systemd units instead of
dracut hooks because it's (not surprisingly) easier to integrate with
other systemd units in the initramfs.
Let's do our part towards eventually phasing out the "init system within
an init system" situation we're in right now and prefer systemd units on
systemd-based initrds.
It also mirrors how unlocking works in the real root.
You can see this similar "don't ship hooks on systemd" pattern in other
dracut modules (for example
04watchdog,50plymouth, and90crypt).