IDP Initiate POST SLO Implementation #131
Conversation
|
Hi, i have remove all the commits relatives to the white spaces. |
|
Did you have a chance to validate my PR? |
|
Hi, can we have an update on this? |
|
@gurtzoo superficially it looks good to me, but unfortunately I do not have the time needed to test it and merge it. Hopefully someone else can do that and post their comments and results here. |
|
@thijskh Can you validate this PR please? |
|
I can have a look, but since SLO is not really widely in use in practice there's no abundance of testing infrastructure. |
|
Hi, yes you are right, on my side i have deployed locally an SP(Apache/Mellon) and test it with an IDP and validate the SLO POST directly. |
There was a problem hiding this comment.
Sorry for the lack of time to review this earlier. I've tested the code and logout works, the metadata generation is broken, see comment. Given the long time this has taken and the simple fix I will fix metadata generation directly after merging this. Thanks!
| @@ -191,6 +191,9 @@ static char *am_generate_metadata(apr_pool_t *p, request_rec *r) | |||
| <SingleLogoutService\n\ | |||
| Binding=\"urn:oasis:names:tc:SAML:2.0:bindings:HTTP-Redirect\"\n\ | |||
| Location=\"%slogout\" />\n\ | |||
| <SingleLogoutService\n\ | |||
| Binding=\"urn:oasis:names:tc:SAML:2.0:bindings:HTTP-POST\"\n\ | |||
| Location=\"%slogout\" />\n\ | |||
There was a problem hiding this comment.
This is added with %s but an extra variable is not added in r215. /mellon/metadata now gives internal server error.
|
Thank you @thijskh for the validation and correction, i appreciate. |
IDP Initiate POST SLO Implementation