Rename the module binary to just pkcs11.so #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simo5
force-pushed
the
so_rename
branch
8 times, most recently
from
c4bc1d1 to
4ce8f21
Compare
holger-dengler
approved these changes
Nov 18, 2022
Jakuje
reviewed
Nov 18, 2022
It is a little bit silly to name a provider something-provider, and other openssl providers just use their name.so (for examnple tpm2.so), so let's do the same for the pkcs11 provider and install it propoerly under /libdir/ossl-modules/pkcs11.so as expected by openssl provider distribution standards. Signed-off-by: Simo Sorce <simo@redhat.com>
Given debian has diffeent libdir directories, better check distcheck there as well. As part of this job seaprate build and distcheck jobs as we do not need the pkcs11 drivers testing matrix for distchecking Signed-off-by: Simo Sorce <simo@redhat.com>
|
@Jakuje rpmbuild seem to work too, can you approve (or disapprove if you think the test is not good) this PR ? |
Jakuje
approved these changes
Nov 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is a little bit silly to name a provider something-provider, and other openssl providers just use their name.so (for examnple tpm2.so), so let's do the same for the pkcs11 provider and install it propoerly under /libdir/ossl-modules/pkcs11.so as expected by openssl provider distribution standards.
Also add a dstribution check CI tests, that runs make distcheck and builds an rpm from the spec file