Implement special parameter to define Key Usage #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fabled will this work for you? |
|
Tests are missing switching to draft |
simo5
force-pushed
the
key_usage
branch
2 times, most recently
from
b88107d to
dd47127
Compare
fabled
reviewed
Sep 7, 2023
|
@fabled updated the relevant code you pointed out, PTAL |
|
Updated with tests |
This allows an application finer control on what usage will be allowed for the key. Fixes latchset#285 Signed-off-by: Simo Sorce <simo@redhat.com>
Signed-off-by: Simo Sorce <simo@redhat.com>
|
Looks good to me. Thank you! |
fabled
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows an application finer control on what usage will be allowed for the key.
Fixes #285