Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the raw point for ECDH public data params #417

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Set the raw point for ECDH public data params #417

merged 1 commit into from
Jul 22, 2024

Conversation

simo5
Copy link
Member

@simo5 simo5 commented Jul 8, 2024 •
edited
Loading

Description

Changes the format of the point passed into ECDH Params

Enables Kryoptic ECDH test, which now passes.

Fixes #416

Checklist

  • Code modified for feature
  • Test suite updated with functionality tests
  • Test suite updated with negative tests
  • [ ] Documentation updated

Reviewer's checklist:

  • Any issues marked for closing are addressed
  • There is a test suite reasonably covering new functionality or modifications
  • [ ] This feature/change has adequate documentation added
  • Code conform to coding style that today cannot yet be enforced via the check style test
  • Commits have short titles and sensible commit messages
  • Coverity Scan has run if needed (code PR) and no new defects were found

@simo5
Set the raw point for ECDH public data params
9f67d0c 
Signed-off-by: Simo Sorce <simo@redhat.com>
@simo5 simo5 requested a review from Jakuje July 8, 2024 22:29
@simo5 simo5 added the covscan Triggers Coverity Scanner label Jul 8, 2024
@github-actions github-actions bot removed the covscan Triggers Coverity Scanner label Jul 8, 2024
@simo5 simo5 added the covscan-ok Coverity scan passed label Jul 8, 2024
Jakuje
Jakuje reviewed Jul 17, 2024
View reviewed changes
src/objects.c Show resolved Hide resolved
Jakuje
Jakuje approved these changes Jul 19, 2024
View reviewed changes
Copy link
Contributor

@Jakuje Jakuje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise lgtm

@simo5 simo5 merged commit c8ebeb2 into latchset:main Jul 22, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jakuje Jakuje Jakuje approved these changes

Assignees
No one assigned
Labels
covscan-ok Coverity scan passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ECDH Params public data should be raw format by default, not DER
2 participants
@simo5 @Jakuje