Off-by-one error in pool consistency check

[glguy]

I'm getting a segmentation fault on this line because pool->objects can be NULL. I suspect this > should be >=, though I'm not quite sure.

Description

Checklist

• Code modified for feature
• Test suite updated with functionality tests
• Test suite updated with negative tests
• Documentation updated

Reviewer's checklist:

• Any issues marked for closing are addressed
• There is a test suite reasonably covering new functionality or modifications
• This feature/change has adequate documentation added
• Code conform to coding style that today cannot yet be enforced via the check style test
• Commits have short titles and sensible commit messages
• Coverity Scan has run if needed (code PR) and no new defects were found

[simo5]

Good catch, but odd that you hit that condition

[glguy]

Thanks for the merge. I'm able to generate that condition in some cases using the PIV application on my YubiKey when I use a sufficiently general URI to query the private key. I haven't narrowed down the actual failure and I understand that ideally this consistency condition should never fail. I know that I can cause it to stop happening when I include ;type=private in my URI. So my hunch is that one of the other object types that pkcs11:id=%01 or pkcs11:id=%02 on my device matches isn't completely supported.