Test operations with pem keys #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes it easier to check what operations each test sends to the token by writing the title of "PARA" sections to the provider's debug file. Signed-off-by: Simo Sorce <simo@redhat.com>
Among other things this tests that a public key sourced by a PEM file gets correctly imported in the token for the on-token ECDH operation. Signed-off-by: Simo Sorce <simo@redhat.com>
If an attribute had an empty value (which is apparently possible with some tokens), the copy function would fail to initialize the pointer causing an invalid free when the attributes array is freed. Ensure pValue is zeroed on copy if the attri bute length is 0, and also ensure the attribute length is correctly set to 0. Then belt&suspender approach ensure the buffer is allocated with OPENSSL_zalloc instead of OPENSSL_malloc, which will eansure by default all addresses and legth are a safe default NULL/0 value. Signed-off-by: Simo Sorce <simo@redhat.com>
Jakuje
approved these changes
Aug 2, 2024
Comment on lines
+27
to
+31
| #title PARA "ECDH Exchange forced: private key in file" | ||
| #ossl ' | ||
| #pkeyutl -derive -inkey ${TESTSSRCDIR}/testp256.pri.pem | ||
| # -peerkey ${ECPEERPUBURI} | ||
| # -out ${TMPPDIR}/forced.pri.ecdh.bin' |
There was a problem hiding this comment.
How much work is adding the support for EC private key export as URI PEM file?
There was a problem hiding this comment.
This is not about export or URI PEM, this is about importing an actual Private key in a PEM file as a session object for use in operations.
Ii is not a commonly needed operation but was one of the goals for using a pkcs11 module as a FIPS token.
It is also necessary if you need to use a private key in a file when default_properties=?pkcs11_provider
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Try to exercise PEM Key import for operations
Related to #305
Checklist
[ ] Code modified for feature[ ] Test suite updated with negative tests[ ] Documentation updatedReviewer's checklist: