Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic Ed448 tests #433

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Add basic Ed448 tests #433

merged 1 commit into from
Aug 22, 2024

Conversation

Jakuje
Copy link
Contributor

@Jakuje Jakuje commented Aug 22, 2024

Description

The pkcs11-tool does not support generating these keys so we just test the internal key generation and processing with tgenkey.

Checklist

  • Code modified for feature
  • Test suite updated with functionality tests
  • Test suite updated with negative tests
  • Documentation updated

Reviewer's checklist:

  • Any issues marked for closing are addressed
  • There is a test suite reasonably covering new functionality or modifications
  • This feature/change has adequate documentation added
  • Code conform to coding style that today cannot yet be enforced via the check style test
  • Commits have short titles and sensible commit messages
  • Coverity Scan has run if needed (code PR) and no new defects were found

The pkcs11-tool does not support generating these keys so we just test
the internal key generation and processing with tgenkey.

Signed-off-by: Jakub Jelen <jjelen@redhat.com>
@Jakuje Jakuje marked this pull request as ready for review August 22, 2024 14:36
@simo5
Copy link
Member

simo5 commented Aug 22, 2024

Good stuff, thank you!

@simo5 simo5 merged commit 7e1584e into latchset:main Aug 22, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants