Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes for git, autotools and library lookup #52

Merged
merged 4 commits into from
Sep 2, 2022

Conversation

holger-dengler
Copy link
Collaborator

@holger-dengler holger-dengler commented Sep 2, 2022

As I started to work with the project, I realized some missing git ignore patterns and files the base automake targets. This series contains some fixes for these issues.

I decided to split my changes into multiple commits, just to make it more clear, what I've changed. But I'm open to merge some of them, if you prefer it.

There are a set f generic ignore patterns, mostly generated by tools
like editors, autotools and build tools. Separate these generic
patterns from the project-specific ones.

Also remove patterns with a path, if they are already covered by
patterns without path (e.g. Makefile covers src/Makefile).

Signed-off-by: Holger Dengler <dengler@linux.ibm.com>
Signed-off-by: Holger Dengler <dengler@linux.ibm.com>
Ignore patterns for files, which are created by the dist or distcheck
targets.

Signed-off-by: Holger Dengler <dengler@linux.ibm.com>
Add missing files to the distclean and maintainer-clean make targets.

Signed-off-by: Holger Dengler <dengler@linux.ibm.com>
@simo5
Copy link
Member

simo5 commented Sep 2, 2022

Failed the gcc build with this in the debug log:
dlopen() failed: libsoftokn3.so: cannot open shared object file: No such file or directory

@holger-dengler
Copy link
Collaborator Author

Ok, let me check that. On my local test machine, the dlopen() with the so-name works properly.

@holger-dengler
Copy link
Collaborator Author

Weird, the library load with only the so-name is workling properly on my debian unstable test env. I will now setup an ubuntu test system first, to check whats going wrong. I decided to drop the two last commits until I have fixed them. Sorry for the noise.

@simo5
Copy link
Member

simo5 commented Sep 2, 2022

Ok, do you want to just merge the current commits and defer the path issue to a different PR?
Either way works for me.

@holger-dengler
Copy link
Collaborator Author

I will create another PR for the soname stuff. You can merge this one as it is, if you're ok with the changes.

@simo5
Copy link
Member

simo5 commented Sep 2, 2022

Sure, I edited the PR description and dropped mention of the softoken path check from there given those patches have been retired.

@simo5 simo5 merged commit 2891d99 into latchset:main Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants