Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bibtex entry with unique double quotation mark causes error #809

Closed
vandalt opened this issue Nov 1, 2022 · 2 comments
Closed

Bibtex entry with unique double quotation mark causes error #809

vandalt opened this issue Nov 1, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@vandalt
Copy link

vandalt commented Nov 1, 2022

Hello,

I have a few bibtex entries with unique double quotation marks (") in the abstract or title (I included an example below in case it helps). They seem to cause an error: opening the .bib file shows the "Expecting a curly bracket" at the end and in the .tex file the autocomplete does not suggest anything after this entry. I don't know if they are supposed to be escaped technically, but I noticed that Overleaf and the LaTeX Workshop VSCode plugin worked fine with them not being escaped. The obvious fix is for me to fix them manually (which I did), but it can be annoying with large, automatically generated bib files (from Zotero, for example), and the error can be confusing so I thought it was still good to open an issue.

Thank you!

@article{doyon_jwst_2012,
  title = {The JWST Fine Guidance Sensor (FGS) and Near-Infrared Imager and Slitless Spectrograph (NIRISS)},
  author = {Doyon, Ren{\'e} and Hutchings, John B. and Beaulieu, Mathilde and Albert, Loic and Lafreni{\`e}re, David and Willott, Chris and Touahri, Driss and Rowlands, Neil and Maszkiewicz, Micheal and Fullerton, Alex W. and Volk, Kevin and Martel, Andr{\'e} R. and Chayer, Pierre and Sivaramakrishnan, Anand and Abraham, Roberto and Ferrarese, Laura and Jayawardhana, Ray and Johnstone, Doug and Meyer, Michael and Pipher, Judith L. and Sawicki, Marcin},
  year = {2012},
  month = sep,
  volume = {8442},
  pages = {84422R},
  doi = {10.1117/12.926578},
  abstract = {The Fine Guidance Sensor (FGS) is one of the four science instruments on board the James Webb Space Telescope (JWST). FGS features two modules: an infrared camera dedicated to fine guiding of the observatory and a science camera module, the Near-Infrared Imager and Slitless Spectrograph (NIRISS) covering the wavelength range between 0.7 and 5.0 {$\mu$}m with a field of view of 2.2' X 2.2'. NIRISS has four observing modes: 1) broadband imaging featuring seven of the eight NIRCam broadband filters, 2) wide-field slitless spectroscopy at a resolving power of rv150 between 1 and 2.5 {$\mu$}m, 3) single-object cross-dispersed slitless spectroscopy enabling simultaneous wavelength coverage between 0. 7 and 2.5 {$\mu$}m at Rrv660, a mode optimized for transit spectroscopy of relatively bright (J {$>$} 7) stars and, 4) sparse aperture interferometric imaging between 3.8 and 4.8 {$\mu$}m enabling high\- contrast ("' 10-4) imaging of M {$<$} 8 point sources at angular separations between 70 and 500 milliarcsec. This paper presents an overview of the FGS/NIRISS design with a focus on the scientific capabilities and performance offered by NIRISS.},
}
pfoerster added a commit that referenced this issue Nov 8, 2022
@pfoerster
Copy link
Member

@vandalt Thanks for the report. There was indeed an error in the parser. Now, it should match the behavior of BibTeX (d3def46).

@pfoerster pfoerster added the bug Something isn't working label Nov 8, 2022
@vandalt
Copy link
Author

vandalt commented Nov 10, 2022

Thanks for the quick fix! It does work on the file I used to report the error now

netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this issue Apr 27, 2023
## [5.5.0] - 2023-04-16

### Added

- Allow optionally passing cursor position to `textDocument/build` request for use in forward search after building.
  Previously, the server had to guess the cursor position ([#475](latex-lsp/texlab#475))
- Add experimental `texlab.experimental.citationCommands` setting to allow extending the list of citation commands
  ([#832](latex-lsp/texlab#832))
- Add support for escaping placeholders in build arguments similar to forward search
- Allow configuring completion matching algorithm ([#872](latex-lsp/texlab#872))

### Fixed

- Fix regression introduced in `v5.4.2` involving `texlab.cleanArtifacts` command.

## [5.4.2] - 2023-04-11

### Fixed

- Fix memory leak when editing documents over a long time ([#856](latex-lsp/texlab#856))
- Fix parsing parentheses in file paths ([#874](latex-lsp/texlab#874))

## [5.4.1] - 2023-03-26

### Fixed

- Do not return symbols with empty names (e. g. sections without name) ([#870](latex-lsp/texlab#870))
- Repair `textDocument/formatting` request ([#871](latex-lsp/texlab#871))

## [5.4.0] - 2023-03-12

### Added

- Add experimental settings to allow extending the list of special environments:
  - `texlab.experimental.mathEnvironments`
  - `texlab.experimental.enumEnvironments`
  - `texlab.experimental.verbatimEnvironments`
- Add `texlab.changeEnvironment` workspace command ([#849](latex-lsp/texlab#849))
- Add `texlab.showDependencyGraph` workspace command

### Changed

- Do not show caption or section names in label inlay hints ([#858](latex-lsp/texlab#858))
- Include more user-defined commands in command completion

### Fixed

- Parse nested `\iffalse` blocks correctly ([#853](latex-lsp/texlab#853))
- Parse commands with multi-byte characters correctly ([#857](latex-lsp/texlab#857))
- Fix checking whether a document can be a root file

## [5.3.0] - 2023-02-25

### Added

- Allow filtering `textDocument/documentSymbols` using regular expressions specified via
  `texlab.symbols.allowedPatterns` and `texlab.symbols.ignoredPatterns`
  ([#851](latex-lsp/texlab#851))

### Fixed

- Do not use percent-encoded path when searching for PDF files during forward search
  ([#848](latex-lsp/texlab#848))
- Always return an empty list of code actions instead of returning "method not found" ([#850](latex-lsp/texlab#850))

## [5.2.0] - 2023-01-29

### Added

- Include line numbers in build warnings when available ([#840](latex-lsp/texlab#840))
- Add `none` formatter to `texlab.latexFormatter` and `texlab.bibtexFormatter` options
  to allow disabling formatting ([#846](latex-lsp/texlab#846))

### Fixed

- Concatenate more than two lines of maximum length in build diagnostics ([#842](latex-lsp/texlab#842))
- Apply the correct range of references to labels when renaming ([#841](latex-lsp/texlab#841))
- Use `document` environment to detect root file instead of `\documentclass` ([#845](latex-lsp/texlab#845))

## [5.1.0] - 2023-01-21

### Added

- Allow manually overriding the root directory using a `texlabroot`/`.texlabroot` marker file.
  See the wiki for more information.
  ([#826](latex-lsp/texlab#826), [#838](latex-lsp/texlab#838))

### Deprecated

- Deprecate `texlab.rootDirectory` setting in favor of `.texlabroot` files

### Fixed

- Do not use `.git`, `.chktexrc`, `.latexmkrc` files/directories to determine the root directory
  ([#826](latex-lsp/texlab#826))
- Fix building documents without an explicit root directory ([#837](latex-lsp/texlab#837))

## [5.0.0] - 2022-12-29

### Changed

- _BREAKING_: `texlab.rootDirectory` is now used as the folder path from which the compiler is executed
  relative to the main document. By default it is equal to `"."`. For more information, please visit the wiki.
- Improve performance of completion by a huge margin due to a faster filtering method used internally
- Do not discover project files beyond the provided workspace folders
- Try to guess the root directory by checking for files such as `.latexmkrc` or `Tectonic.toml` if `texlab.rootDirectory` is not set

### Fixed

- Update positions of reported build diagnostics when editing the affected line
- Do not treat links to files as bidirectional by default. This prevents issues where `texlab` ends up compiling the wrong file
  in projects with shared files ([#806](latex-lsp/texlab#806), [#757](latex-lsp/texlab#757), [#679](latex-lsp/texlab#679))
- Fix coverage of directories which need to be watched for changes ([#502](latex-lsp/texlab#502), [#491](latex-lsp/texlab#491))
- Resolve links of the `import` package correctly
- Use `filterText` of completion items when filtering internally ([#829](latex-lsp/texlab#829))

## [4.3.2] - 2022-11-20

### Fixed

- Do not try to run the TeX engine on package files and fail the build instead ([#801](latex-lsp/texlab#801))
- Handle URIs with URL-encoded drive letters on Windows ([#802](latex-lsp/texlab#802))
- Parse BibTeX entries with unbalanced quotes correctly ([#809](latex-lsp/texlab#809))
- Provide completion for more acronym commands ([#813](latex-lsp/texlab#813))
- Fix parsing acronym definitions ([#813](latex-lsp/texlab#813))

## [4.3.1] - 2022-10-22

### Fixed

- Do not crash with a stack overflow when trying to load packages with many internal dependencies ([#793](latex-lsp/texlab#793))
- Normalize drive letters of all document URIs
- Fix parsing commands that take file paths as arguments ([#789](latex-lsp/texlab#789))
- Use the correct working directory and command line arguments when calling `latexindent` ([#645](latex-lsp/texlab#645))
- Fix publishing to CTAN

## [4.3.0] - 2022-09-25

### Added

- Add inlay hints for `\label{...}` ([#753](latex-lsp/texlab#753))

### Fixed

- Improve accuracy of the error locations reported by the TeX engine ([#738](latex-lsp/texlab#738))
- Reduce number of false positive errors reported by `texlab` ([#745](latex-lsp/texlab#745))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants