Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix bibitem undefined #1244

Merged
merged 5 commits into from
Oct 20, 2024

Conversation

nolanking90
Copy link
Contributor

@nolanking90 nolanking90 commented Oct 19, 2024

Fixes #1171
Add a bibitem list to the latex Semantics struct, bibitem to CommandName and SyntaxKind enums, and handlers for processing bibitem nodes in a tex document.
Added checks against the bibitem list for undefined references and unused references.

Tested in NVIM v0.11.0-dev-386+g545aafbeb
w/ following minimum working example

\documentclass{article}

\begin{document}

See~\cite{ref1} % No error
See~\cite{ref2} % Undefied Reference Error

\begin{thebibliography}{9}
  \bibitem{ref1}
  Donald E. Knuth (1986) \emph{The \TeX{} Book}, Addison-Wesley Professional.

  \bibitem{ref3} % Unused Reference Warning
  An unused reference
\end{thebibliography}

\end{document}

@nolanking90 nolanking90 marked this pull request as ready for review October 19, 2024 14:42
@pfoerster pfoerster merged commit d9ac8a1 into latex-lsp:master Oct 20, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False undefined reference error with thebibliography
2 participants