Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve project detection algorithm using salsa crate #823

Merged
merged 63 commits into from
Dec 29, 2022
Merged

Conversation

pfoerster
Copy link
Member

@pfoerster pfoerster commented Nov 22, 2022

This PR improves the current project detection algorithm used to build a dependency graph and load the missing files from the disk. It uses the salsa crate (salsa-2022 to be exact) and fixes many long-standing bugs:

A more detailed changelog can be seen here: https://github.com/latex-lsp/texlab/blob/salsa/CHANGELOG.md#unreleased

In particular, the meaning of texlab.rootDirectory has changed:
Consider the following project structure:

| project
|-- src
    |-- main.tex
|-- build
    |-- main.pdf
    |-- main.log
    |-- main.aux

Then you need to set texlab.rootDirectory to ".." and texlab.auxDirectory to build. As a consequence, texlab no longer depends on the working dir passed to the process.

@pfoerster pfoerster merged commit 7852a09 into master Dec 29, 2022
@pfoerster pfoerster deleted the salsa branch December 29, 2022 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment