feat(create-mud): use new sync packages #1214
Conversation
🦋 Changeset detectedLatest commit: d4984cc The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
holic
force-pushed
the
holic/template-sync-stack
branch
from
363c885
to
9858d12
Compare
| 2. In your `supportedChains.ts`, replace `foundry` chain with our new `mudFoundry` chain. | ||
|
|
||
| ```diff | ||
| - import { foundry } from "viem/chains"; | ||
| - import { MUDChain, latticeTestnet } from "@latticexyz/common/chains"; | ||
| + import { MUDChain, latticeTestnet, mudFoundry } from "@latticexyz/common/chains"; | ||
|
|
||
| - export const supportedChains: MUDChain[] = [foundry, latticeTestnet]; | ||
| + export const supportedChains: MUDChain[] = [mudFoundry, latticeTestnet]; | ||
| ``` |
There was a problem hiding this comment.
is this part still necessary? or do we want to keep it so we can add stuff to mudFoundry in the future?
There was a problem hiding this comment.
I think it's worth keeping for now since we've discovered a couple reasons to hook into viem internals
There was a problem hiding this comment.
a reason to keep it: wevm/viem#1006
| - : world?.blockNumber ?? -1; // -1 will attempt to find the block number from RPC | ||
| + : world?.blockNumber ?? 0n; |
There was a problem hiding this comment.
do we currently have some mechanism to look for the HelloWorld event? or load it from the worlds.json file?
There was a problem hiding this comment.
nvm world?.blockNumber already grabs it from the worlds.json
There was a problem hiding this comment.
I am imagining in the future syncToRecs will attempt to find a HelloStore event emission (which will also have things like protocol version)
Co-authored-by: alvarius <alvarius@lattice.xyz>
There was a problem hiding this comment.
big props on this changeset, this is by far the best changeset we have so far
| // KeysWithValue doesn't seem to like singleton keys | ||
| // modules: [ | ||
| // { | ||
| // name: "KeysWithValueModule", | ||
| // root: true, | ||
| // args: [resolveTableId("CounterTable")], | ||
| // }, | ||
| // ], |
Updates all templates to use new sync packages
Waiting on wevm/viem#963 so we don't need zero-fee overrides everywhere