feat(store-indexer,store-sync): make chain optional, configure indexer with RPC #1234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 027c4f1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 27 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
holic
changed the title
alvrs
reviewed
Aug 3, 2023
Comment on lines
36
to
41
| const chain = env.CHAIN_ID ? possibleChains.find((c) => c.id === env.CHAIN_ID) : undefined; | ||
|
|
||
| const transports: Transport[] = [ | ||
| env.RPC_WS_URL ? webSocket(env.RPC_WS_URL) : null, | ||
| env.RPC_HTTP_URL ? http(env.RPC_HTTP_URL) : null, | ||
| ].filter(isNotNull); |
There was a problem hiding this comment.
should we throw an error if neither CHAIN_ID nor RPC_HTTP_URL/RPC_WS_URL are set?
alvrs
previously approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed to make the indexed configurable with just RPC URLs