-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove v1 network package, remove snap sync module, deprecate std-client #1311
Conversation
🦋 Changeset detectedLatest commit: 0dddaef The changes in this PR will be included in the next version bump. This PR includes changesets to release 26 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
e71f896
to
b2a0d7f
Compare
2c68257
to
b806818
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥🔥🔥
.changeset/wild-gorillas-care.md
Outdated
@@ -0,0 +1,27 @@ | |||
--- | |||
"@latticexyz/std-client": major | |||
"@latticexyz/common": major |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be a minor
since its a new feature, not a breaking change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep good catch!
@@ -36,6 +36,7 @@ | |||
"@vitejs/plugin-react": "^4.0.0", | |||
"eslint-plugin-react": "7.31.11", | |||
"eslint-plugin-react-hooks": "4.6.0", | |||
"jsdom": "^22.1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any idea why this suddenly appeared?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my assumption is that it was somehow available because of some dependency of the network package
std-client
, move some functions to other packages, remove those that depended on old network code, and move the rest to/deprecated
For more context, see this PR's changesets.