Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove v1 network package, remove snap sync module, deprecate std-client #1311

Merged
merged 13 commits into from
Aug 16, 2023

Conversation

alvrs
Copy link
Member

@alvrs alvrs commented Aug 15, 2023

  • Remove the v1 network package to unblock a couple protocol changes that require changes to the sync code (so we only have to integrate it in the new sync code)
  • Deprecate std-client, move some functions to other packages, remove those that depended on old network code, and move the rest to /deprecated
  • Remove the snap sync module

For more context, see this PR's changesets.

@changeset-bot
Copy link

changeset-bot bot commented Aug 15, 2023

🦋 Changeset detected

Latest commit: 0dddaef

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 26 packages
Name Type
@latticexyz/world Major
@latticexyz/services Major
create-mud Major
@latticexyz/std-client Major
@latticexyz/common Major
@latticexyz/cli Major
@latticexyz/dev-tools Major
@latticexyz/store-sync Major
@latticexyz/ecs-browser Major
@latticexyz/block-logs-stream Major
@latticexyz/config Major
@latticexyz/protocol-parser Major
@latticexyz/store-cache Major
@latticexyz/store-indexer Major
@latticexyz/store Major
@latticexyz/react Major
@latticexyz/gas-report Major
@latticexyz/noise Major
@latticexyz/phaserx Major
@latticexyz/recs Major
@latticexyz/schema-type Major
@latticexyz/solecs Major
solhint-config-mud Major
solhint-plugin-mud Major
@latticexyz/std-contracts Major
@latticexyz/utils Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@alvrs alvrs marked this pull request as ready for review August 15, 2023 17:47
@alvrs alvrs requested a review from holic as a code owner August 15, 2023 17:47
@alvrs alvrs requested a review from a user August 15, 2023 17:47
holic
holic previously approved these changes Aug 16, 2023
Copy link
Member

@holic holic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥🔥🔥

@@ -0,0 +1,27 @@
---
"@latticexyz/std-client": major
"@latticexyz/common": major
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be a minor since its a new feature, not a breaking change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep good catch!

@@ -36,6 +36,7 @@
"@vitejs/plugin-react": "^4.0.0",
"eslint-plugin-react": "7.31.11",
"eslint-plugin-react-hooks": "4.6.0",
"jsdom": "^22.1.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any idea why this suddenly appeared?

Copy link
Member Author

@alvrs alvrs Aug 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my assumption is that it was somehow available because of some dependency of the network package

.changeset/fair-papayas-add.md Outdated Show resolved Hide resolved
@alvrs alvrs merged commit 331f0d6 into main Aug 16, 2023
9 checks passed
@alvrs alvrs deleted the alvrs/remove-v1-network branch August 16, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants