Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: refactor docker build #2783

Merged
merged 3 commits into from
May 1, 2024
Merged

ci: refactor docker build #2783

merged 3 commits into from
May 1, 2024

Conversation

holic
Copy link
Member

@holic holic commented May 1, 2024

attempting to refactor the docker build step so that they run in order on the same worker, rather than separate workers all performing the same work (building a big docker image)

Copy link

changeset-bot bot commented May 1, 2024

⚠️ No Changeset found

Latest commit: d56cf07

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@holic holic force-pushed the holic/refactor-docker-build branch 2 times, most recently from 7a880bb to 6e4300a Compare May 1, 2024 20:56
alvrs
alvrs previously approved these changes May 1, 2024
@holic holic marked this pull request as ready for review May 1, 2024 21:43
@holic holic requested a review from yonadaaa as a code owner May 1, 2024 21:43
Base automatically changed from holic/release-before-snapshot to main May 1, 2024 21:48
@holic holic dismissed alvrs’s stale review May 1, 2024 21:48

The base branch was changed.

@holic holic merged commit b6c60a0 into main May 1, 2024
11 of 12 checks passed
@holic holic deleted the holic/refactor-docker-build branch May 1, 2024 22:03
@holic holic mentioned this pull request May 2, 2024
@kylegalbraith
Copy link

@holic I was taking a look at your Depot usage and wanted to suggest that you have 5,000 accelerated Docker image build minutes with us. You could cut these Docker image builds over to a Depot project or two and get significantly faster Docker image builds to go with the GHA runners you are already using. Here are some docs on getting going with that, but feel free to ping @jacobwgillespie or me if we can help out: https://depot.dev/docs/integrations/github-actions

dhvanipa pushed a commit to tenetxyz/mud that referenced this pull request May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants