refactor: rename fileSelector to name
#610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvrs
force-pushed
the
alvrs/renamefileselector
branch
from
5b45ee0
to
b0c74b2
Compare
alvrs
changed the title
fileSelector to name
|
looks like you need to run tsgen somewhere nice to finally see that new build step fail, I don't love the lack of visibility on what failed from the steps run, so I'm gonna revert that "composite" change I made |
|
if it's tsgen then you need to do |
alvrs
force-pushed
the
alvrs/renamefileselector
branch
from
bb4a843
to
81edeee
Compare
holic
previously approved these changes
Apr 12, 2023
alvrs
force-pushed
the
alvrs/renamefileselector
branch
from
81edeee
to
ced5245
Compare
holic
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fileSelectortonamebytes32resource selector, which consists of two parts: abytes16"namespace" and abytes16"fileSelector". This "fileSelector" is just the name of the resource within the namespace, and calling it "fileSelector" was very confusing for people, so in this PR we're changing it to "name".