Skip to content
This repository has been archived by the owner on Jul 25, 2022. It is now read-only.

Multi-server model #53

Merged
merged 8 commits into from
Apr 15, 2018
Merged

Multi-server model #53

merged 8 commits into from
Apr 15, 2018

Conversation

laughedelic
Copy link
Owner

Ensime was added a while ago (but not exposed): #3, Dotty LS got in recently too: #48, but the way it worked was very cumbersome: user needs to choose 1 server he want to use all the time and when you want to switch, you have to reload the plugin/editor.

This plugin makes some refactoring to make different servers more obvious in the code and adds new feature: automatic choice of language server based on the project setup:

  • if .ide-dotty-artifact file is around, it's a Dotty project
  • if .metals folder is around, it's a Metals project
  • if .ensime file is around, it's an Ensime project
  • otherwise launch default server and warn user to setup the project

and the server gets chosen every time you open a new project in Atom.

screen shot 2018-04-14 at 18 52 25

screen shot 2018-04-14 at 18 54 27

User can choose default server in the settings. Probably it's better not to launch any server at all if the project is not setup yet. So far none of the servers can setup themselves completely autonomously (i.e. they require user to use some sbt plugin and run some commands, see https://github.com/scalacenter/load-plugin).

@laughedelic laughedelic added this to the BIG release milestone Apr 14, 2018
@laughedelic laughedelic self-assigned this Apr 14, 2018
@laughedelic
Copy link
Owner Author

Better notifications:

screen shot 2018-04-15 at 00 46 11

screen shot 2018-04-15 at 01 01 38

And the case when user can choose which server to launch:

screen shot 2018-04-15 at 01 15 55

@laughedelic
Copy link
Owner Author

laughedelic commented Apr 15, 2018

Better new project warnings:

  • auto == true & default == none:

    screen shot 2018-04-15 at 03 51 07
  • auto == true & default != none:

    screen shot 2018-04-15 at 03 52 00

Probably they look too similar... 🤔 I'll fix it later.

Plus the "muted" case: auto == false & default == none

screen shot 2018-04-15 at 03 55 03

@laughedelic laughedelic merged commit 648269f into master Apr 15, 2018
@laughedelic laughedelic deleted the multi-server branch April 15, 2018 01:56
@laughedelic laughedelic mentioned this pull request Apr 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant