Skip to content

Commit

Permalink
Dont use EXPLAIN in nullability check for QuestDB
Browse files Browse the repository at this point in the history
  • Loading branch information
SuficioAC committed Dec 16, 2024
1 parent 1678b19 commit 8a44f35
Showing 1 changed file with 6 additions and 12 deletions.
18 changes: 6 additions & 12 deletions sqlx-postgres/src/connection/describe.rs
Original file line number Diff line number Diff line change
Expand Up @@ -486,18 +486,12 @@ WHERE rngtypid = $1
)
})?;

// If the server is CockroachDB or Materialize, skip this step (#1248).
if !self
.inner
.stream
.parameter_statuses
.contains_key("crdb_version")
&& !self
.inner
.stream
.parameter_statuses
.contains_key("mz_version")
{
// If the server doesn't support EXPLAIN statements, skip this step (#1248).
let parameter_statuses = &self.inner.stream.parameter_statuses;
let is_cockroachdb = parameter_statuses.contains_key("crdb_version");
let is_materialize = parameter_statuses.contains_key("mz_version");
let is_questdb = parameter_statuses.contains_key("questdb_version");
if !is_cockroachdb && !is_materialize && !is_questdb {
// patch up our null inference with data from EXPLAIN
let nullable_patch = self
.nullables_from_explain(stmt_id, meta.parameters.len())
Expand Down

0 comments on commit 8a44f35

Please sign in to comment.