Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(postgres): Match ~/.pgpass password after URL parsing and fix user and database ordering #1566

Merged
merged 4 commits into from
Dec 29, 2021
Merged

fix(postgres): Match ~/.pgpass password after URL parsing and fix user and database ordering #1566

merged 4 commits into from
Dec 29, 2021

Conversation

D1plo1d
Copy link
Contributor

@D1plo1d D1plo1d commented Dec 2, 2021

This fixes two bugs in loading postgres passwords from ~/.pgpass files:

  • pgpass was applied before parsing the database URLs so it wasn't matching against the host/port/user/database from the URL provided
  • pgpass was matching user and database in the wrong order

@D1plo1d D1plo1d changed the title fix(postgres): Fixes pgpass so it applies after parsing and matches usernames & databases correctly fix(postgres): Match ~/.pgpass password after parsing and fix user and database ordering Dec 2, 2021
@D1plo1d D1plo1d changed the title fix(postgres): Match ~/.pgpass password after parsing and fix user and database ordering fix(postgres): Match ~/.pgpass password after URL parsing and fix user and database ordering Dec 2, 2021
@abonander
Copy link
Collaborator

@D1plo1d looks like cargo fmt just needs to be run and this is good to go.

@abonander abonander merged commit f79d321 into launchbadge:master Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abonander abonander abonander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@D1plo1d @abonander