Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example with external query files #1932

Closed
wants to merge 0 commits into from

Conversation

JoeyMckenzie
Copy link
Contributor

@JoeyMckenzie JoeyMckenzie commented Jun 27, 2022

First and foremost, after being relatively new to Rust, sqlx made it incredibly easy to dive right into data-driven applications with a great straightforward API and docs to match. The docs touch on query_file!() and query_as_file!() (along with the other variants), but I thought it would be nice to include a Postgres-based example as well (recently did this in a personal project). Great work!

@Anastasia1510

This comment was marked as spam.

@abonander
Copy link
Collaborator

It looks like you've made a bit of a mess of your commit history here. I'd recommend doing an interactive rebase to get it down to just your commits and then rebase onto main instead of merging main into your fork.

@abonander
Copy link
Collaborator

Alternatively, you could copy your changes into a fresh clone against a new branch, and then reset this branch to it.

@JoeyMckenzie
Copy link
Contributor Author

@abonander whoops, didn't catch that while syncing forks. Updated, looks like the originally intended change now.

@abonander
Copy link
Collaborator

You still have 9 or so superfluous commits there that I don't want to add to the repo's history. Can you please rebase instead of pulling? There's a merge conflict from #1802 to fix anyway.

@abonander
Copy link
Collaborator

Well, don't worry about the extra commits since I'll do a squash on merge anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants