Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use separate temp dir for query jsons (2) #2803

Merged
merged 3 commits into from
Oct 17, 2023
Merged

Don't use separate temp dir for query jsons (2) #2803

merged 3 commits into from
Oct 17, 2023

Conversation

mattfbacon
Copy link
Contributor

Replaces #2787 and fixes #2663

jplatte
jplatte approved these changes Oct 8, 2023
View reviewed changes
Copy link
Contributor

@jplatte jplatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the PR title is a bit misleading with what the PR does now. The code change should be a clear improvement though. Maybe my approval will help this get merged a bit faster ^^

@mattfbacon mattfbacon changed the title Don't use temp dir for query jsons 2 Don't use separate temp dir for query jsons (2) Oct 8, 2023
@abonander abonander merged commit b16fbeb into launchbadge:main Oct 17, 2023
64 checks passed
@abonander abonander mentioned this pull request Oct 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jplatte jplatte jplatte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Invalid cross-device link" when generating query files
3 participants
@mattfbacon @jplatte @abonander