Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement SASL Authentication #37

Merged
merged 5 commits into from
Jan 11, 2020
Merged

Implement SASL Authentication #37

merged 5 commits into from
Jan 11, 2020

Conversation

janaakhterov
Copy link
Contributor

No description provided.

@janaakhterov janaakhterov added the db:postgres Related to PostgreSQL label Jan 9, 2020
@janaakhterov janaakhterov self-assigned this Jan 9, 2020
mehcode
mehcode requested changes Jan 9, 2020
View reviewed changes
Cargo.toml Show resolved Hide resolved
sqlx-core/Cargo.toml Outdated Show resolved Hide resolved
sqlx-core/src/postgres/connection.rs Outdated Show resolved Hide resolved
sqlx-core/src/postgres/protocol/authentication.rs Outdated Show resolved Hide resolved
sqlx-core/src/postgres/protocol/authentication.rs Outdated Show resolved Hide resolved
sqlx-core/src/postgres/protocol/sasl.rs Outdated Show resolved Hide resolved
sqlx-core/src/postgres/protocol/sasl.rs Outdated Show resolved Hide resolved
sqlx-core/src/postgres/protocol/sasl.rs Outdated Show resolved Hide resolved
tests/postgres.rs Outdated Show resolved Hide resolved
sqlx-core/src/postgres/protocol/sasl.rs Outdated Show resolved Hide resolved
@mehcode mehcode changed the title Implememnt SASL Authentication Implement SASL Authentication Jan 10, 2020
@janaakhterov janaakhterov force-pushed the feature/postgres-auth branch from 898c84f to 96c23a8 Compare January 11, 2020 00:49
janaakhterov and others added 2 commits January 11, 2020 03:33
@janaakhterov @mehcode
Implememnt SASL Authentication
507d988
@janaakhterov @mehcode
Resolve Comments
db230e2 
    - Remove `hex` from root `Cargo.toml`
    - Make `hmac` crate optional
    - Clean up checking mechanisms for "SCRAM-SHA-256"
    - Use `str::from_utf8` instead of `String::from_utf8_lossyf
    - Update `Sasl*Response` structs be tuple structs
    - Factor out `len` in `SaslInitialResponse.encode()`
    - Use `protocol_err` instead of `expect` when constructing `Hmacf
      instances
    - Remove `it_connects_to_database_user` test as it was too fragile
    - Move `sasl_auth` function into `postgres/connection` as it more
      related to `Connection` rather than `protocl`
    - Return an error when decoding base64 salt rather than panicing
      in `Authentication::SaslContinue`
@mehcode mehcode force-pushed the feature/postgres-auth branch from 96c23a8 to db230e2 Compare January 11, 2020 11:33
@mehcode mehcode merged commit 9b50dcc into master Jan 11, 2020
@mehcode mehcode deleted the feature/postgres-auth branch January 12, 2020 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mehcode mehcode mehcode requested changes

@abonander abonander Awaiting requested review from abonander

Assignees

@janaakhterov janaakhterov

Labels
db:postgres Related to PostgreSQL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@janaakhterov @mehcode @abonander