Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade async runtime dependencies (tokio 1.0, actix-rt 2.0.0-beta.2) #983

Merged
merged 5 commits into from
Jan 21, 2021

Conversation

jplatte
Copy link
Contributor

@jplatte jplatte commented Jan 14, 2021

@seryl @ant32 I took your git identity from the respective previous commits and used them for Co-authored-by. Let me know if this is okay for you / whether you want me to remove your email address (that's already public but not on the GitHub web interface otherwise) or anything like that.

Supersedes #794.

Co-authored-by: Josh Toft <joshtoft@gmail.com>
Co-authored-by: Philip A Reimer <antreimer@gmail.com>
@jplatte
Copy link
Contributor Author

jplatte commented Jan 14, 2021

Please consider also merging #976 before the next release 🙂

@ant32
Copy link
Contributor

ant32 commented Jan 14, 2021

@jplatte yes you can gladly use my work here and add my email address. I see you did a much better job and am enjoying looking at how you did things differently.

@seryl
Copy link
Contributor

seryl commented Jan 14, 2021

@jplatte I'm on the same page, glad someone was able to take this to completion.

You're more than welcome to use my work and add my email address.

@ant32
Copy link
Contributor

ant32 commented Jan 14, 2021

actix-rt 2.0.0-beta.2 is out. Maybe the dependency could be updated.

@jplatte jplatte changed the title Upgrade async runtime dependencies (tokio 1.0, actix-rt 2.0.0-beta.1) Upgrade async runtime dependencies (tokio 1.0, actix-rt 2.0.0-beta.2) Jan 14, 2021
@rich-murphey
Copy link
Contributor

Wow, upgrading to this was as easy as changing dependencies. Kudos!

@HTGAzureX1212
Copy link

I am currently working on a Discord bot and it uses tokio 1.0 I am really looking forward to this PR merged!

@dfioravanti
Copy link

I was wondering if there a rough timeline about when will this be merged? I am building an app to learn tokio and rust and I would really like to use sqlx. I absolutely understand that this is not a small change but are we talking about days/weeks/months?

@jplatte
Copy link
Contributor Author

jplatte commented Jan 17, 2021

From my experience, I'd expect this to be either reviewed or merged in the coming days.

@dfioravanti
Copy link

Sorry, let me rephrase. I know they are working on 0.5 which include some significant changes. Will this be available as 0.4.3, which does not follow semver as it would probably break everything that relies on tokio <0.3 or do we need to wait until 0.5?

@jplatte
Copy link
Contributor Author

jplatte commented Jan 17, 2021

No, this will be in 0.5, the big API changes are going to be in 0.6. @mehcode you may want to update the title of #909 🙂

@dfioravanti
Copy link

Cool, thanks for letting us know =)

@dragonnn dragonnn mentioned this pull request Jan 17, 2021
@BlackHoleFox
Copy link
Contributor

This is much nicer then what I had stashed locally, well done :D Looking forward to this merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants