Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

identify() future may not complete if device is backgrounded during the call #91

Closed
gwhelanLD opened this issue Nov 19, 2019 · 3 comments
Assignees

Comments

@gwhelanLD
Copy link
Contributor

Are you sure it's correctly fixed? I'm facing a similar issue with 2.9.0.

I basically have wrapped all LD interactions in Rx streams. And at some point it involves having identify calls running on a specific (non-main) thread.

But if the app goes into the background when identify() is being called, the call is cancelled, the event, the connection is shut down

And identify().get() will never return, no matter if I retry it after a timeout.

I had to downgrade to 2.7.0 to have it work as expected.

Originally posted by @drommk in #86 (comment)

@gwhelanLD
Copy link
Contributor Author

@drommk,

We'll investigate this issue and try to replicate. Any more specific info on your Rx streams involved in the interactions with the LaunchDarkly Android SDK may be helpful in tracking the issue down.

Thanks,
@gwhelanLD

@bwoskow-ld
Copy link
Member

Filed internally as 62120

gwhelanLD pushed a commit that referenced this issue Jan 30, 2020
Added version and flagVersion retrieval from ping events if available
@gwhelanLD
Copy link
Contributor Author

Hi @drommk,

We revisited the completion cases of the Future returned by the init and identify for the 2.11.0 release and improved our test coverage of this area. Hopefully the changes should address your difficulties with the completion of the Future. I'm closing this issue as I believe we have addressed the cases that could lead to the cases you described, but feel free to reopen if you run into the same issue.

Thanks,
@gwhelanLD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants