Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deprecating init without timeout #264

Merged
merged 2 commits into from
Apr 25, 2024

Conversation

tanderson-ld
Copy link
Contributor

@tanderson-ld tanderson-ld commented Apr 24, 2024

Requirements

  • I have added test coverage for new or changed functionality - N/A

  • I have followed the repository's pull request submission guidelines

  • I have validated my changes against all supported platform versions - N/A, no platform dependencies changed and CI tests have sufficient coverage.

Related issues
238624

BEGIN_COMMIT_OVERRIDE
feat: deprecating init without timeout
END_COMMIT_OVERRIDE

@tanderson-ld tanderson-ld requested a review from a team April 24, 2024 20:52
@kinyoklion
Copy link
Member

I think we should consider a feat: for this instead of fix as it adds functionality.

@tanderson-ld tanderson-ld changed the title fix: deprecating init without timeout feat: deprecating init without timeout Apr 25, 2024
@tanderson-ld tanderson-ld merged commit 1e46f0d into main Apr 25, 2024
2 checks passed
@tanderson-ld tanderson-ld deleted the ta/sc-238624/deprecate-init-without-timeout branch April 25, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants