Skip to content
lint

feat: add LDValue_SerializeJSON C binding #1905

Sign in to view logs

feat: add LDValue_SerializeJSON C binding

feat: add LDValue_SerializeJSON C binding #1905

Triggered via pull request October 17, 2024 01:41
@cwaldren-ldcwaldren-ld
synchronize #458
cw/sdk-779-ldvalue-serialize
Status Success
Total duration 3m 58s
Artifacts –

cpp-linter.yml

on: pull_request
cpp-linter
3m 48s
cpp-linter
Fit to window
Zoom out
Zoom in

Annotations

10 warnings and 4 notices
/libs/client-sdk/src/data_sources/data_source_event_handler.cpp:46:54 [bugprone-unchecked-optional-access]: libs/client-sdk/src/data_sources/data_source_event_handler.cpp#L46
unchecked access to optional value
/libs/client-sdk/src/data_sources/data_source_event_handler.cpp:75:5 [modernize-pass-by-value]: libs/client-sdk/src/data_sources/data_source_event_handler.cpp#L75
pass by value and use std::move
/libs/client-sdk/src/data_sources/data_source_event_handler.cpp:85:5 [bugprone-easily-swappable-parameters]: libs/client-sdk/src/data_sources/data_source_event_handler.cpp#L85
2 adjacent parameters of 'HandleMessage' of similar type ('const std::string &') are easily swapped by mistake
/libs/client-sdk/src/flag_manager/flag_persistence.cpp:17:26 [cppcoreguidelines-pro-type-reinterpret-cast]: libs/client-sdk/src/flag_manager/flag_persistence.cpp#L17
do not use reinterpret_cast
/libs/client-sdk/src/flag_manager/flag_persistence.cpp:32:34 [modernize-pass-by-value]: libs/client-sdk/src/flag_manager/flag_persistence.cpp#L32
pass by value and use std::move
/libs/client-sdk/src/flag_manager/flag_persistence.cpp:38:21 [performance-unnecessary-value-param]: libs/client-sdk/src/flag_manager/flag_persistence.cpp#L38
parameter 'time_stamper' is passed by value and only copied once; consider moving it to avoid unnecessary copies
/libs/client-sdk/src/flag_manager/flag_persistence.cpp:109:24 [readability-identifier-length]: libs/client-sdk/src/flag_manager/flag_persistence.cpp#L109
variable name 'v' is too short, expected at least 3 characters
/libs/client-sdk/src/flag_manager/flag_persistence.cpp:129:60 [performance-move-const-arg]: libs/client-sdk/src/flag_manager/flag_persistence.cpp#L129
passing result of std::move() as a const reference argument; no move will actually happen
/libs/client-sdk/src/flag_manager/flag_persistence.cpp:133:12 [modernize-return-braced-init-list]: libs/client-sdk/src/flag_manager/flag_persistence.cpp#L133
avoid repeating the return type from the declaration; use a braced initializer list instead
/libs/common/tests/bindings/value_test.cpp:36:35 [cppcoreguidelines-avoid-magic-numbers: libs/common/tests/bindings/value_test.cpp#L36
17 is a magic number; consider replacing it with a named constant
Run clang-format on libs/client-sdk/src/data_sources/data_source_event_handler.cpp: libs/client-sdk/src/data_sources/data_source_event_handler.cpp#L1
File libs/client-sdk/src/data_sources/data_source_event_handler.cpp does not conform to Custom style guidelines. (lines 3)
Run clang-format on libs/client-sdk/src/flag_manager/flag_persistence.cpp: libs/client-sdk/src/flag_manager/flag_persistence.cpp#L1
File libs/client-sdk/src/flag_manager/flag_persistence.cpp does not conform to Custom style guidelines. (lines 6)
Run clang-format on libs/internal/src/serialization/json_context.cpp: libs/internal/src/serialization/json_context.cpp#L1
File libs/internal/src/serialization/json_context.cpp does not conform to Custom style guidelines. (lines 1)
Run clang-format on libs/server-sdk/src/integrations/data_reader/kinds.cpp: libs/server-sdk/src/integrations/data_reader/kinds.cpp#L1
File libs/server-sdk/src/integrations/data_reader/kinds.cpp does not conform to Custom style guidelines. (lines 3)