Skip to content
lint

refactor!: move server side config into lib/server #1241

Sign in to view logs

refactor!: move server side config into lib/server

refactor!: move server side config into lib/server #1241

Triggered via pull request November 3, 2023 22:10
@cwaldren-ldcwaldren-ld
synchronize #283
cw/sc-223686/config-refactor
Status Success
Total duration 4m 3s
Artifacts –

cpp-linter.yml

on: pull_request
cpp-linter
3m 53s
cpp-linter
Fit to window
Zoom out
Zoom in

Annotations

10 warnings
/examples/hello-cpp-server/main.cpp:9:9 [cppcoreguidelines-macro-usage]: examples/hello-cpp-server/main.cpp#L9
macro 'SDK_KEY' used to declare a constant; consider using a 'constexpr' constant
/examples/hello-cpp-server/main.cpp:12:9 [cppcoreguidelines-macro-usage]: examples/hello-cpp-server/main.cpp#L12
macro 'FEATURE_FLAG_KEY' used to declare a constant; consider using a 'constexpr' constant
/examples/hello-cpp-server/main.cpp:16:1 [modernize-macro-to-enum]: examples/hello-cpp-server/main.cpp#L16
replace macro with enum
/examples/hello-cpp-server/main.cpp:16:9 [cppcoreguidelines-macro-usage]: examples/hello-cpp-server/main.cpp#L16
macro 'INIT_TIMEOUT_MILLISECONDS' used to declare a constant; consider using a 'constexpr' constant
/examples/hello-cpp-server/main.cpp:16:9 [modernize-macro-to-enum]: examples/hello-cpp-server/main.cpp#L16
macro 'INIT_TIMEOUT_MILLISECONDS' defines an integral constant; prefer an enum instead
/examples/hello-cpp-server/main.cpp:20:10 [readability-implicit-bool-conversion]: examples/hello-cpp-server/main.cpp#L20
implicit conversion 'size_t' (aka 'unsigned long') -> bool
/examples/hello-cpp-server/main.cpp:21:9 [cppcoreguidelines-pro-type-vararg]: examples/hello-cpp-server/main.cpp#L21
do not call c-style vararg functions
/libs/common/tests/config_builder_test.cpp:10:26 [cppcoreguidelines-non-private-member-variables-in-classes]: libs/common/tests/config_builder_test.cpp#L10
member variable 'logger' has protected visibility
/libs/common/tests/config_builder_test.cpp:79:43 [cppcoreguidelines-avoid-magic-numbers: libs/common/tests/config_builder_test.cpp#L79
5000 is a magic number; consider replacing it with a named constant
/libs/common/tests/config_builder_test.cpp:108:51 [cppcoreguidelines-avoid-magic-numbers: libs/common/tests/config_builder_test.cpp#L108
1234 is a magic number; consider replacing it with a named constant