Skip to content

Commit

Permalink
build: slight renaming of provenance output to meet best practice
Browse files Browse the repository at this point in the history
  • Loading branch information
rsoberano-ld committed Sep 11, 2023
1 parent 6876f69 commit ac9f745
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 10 deletions.
8 changes: 4 additions & 4 deletions .github/actions/sdk-release/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,9 @@ outputs:
hashes-windows:
description: "base64-encoded sha256 hash of windows build artifacts"
value: ${{ steps.hash-windows.outputs.hashes-windows }}
hashes-macos:
hashes-mac:
description: "base64-encoded sha256 hash of macos build artifacts"
value: ${{ steps.hash-macos.outputs.hashes-macos }}
value: ${{ steps.hash-mac.outputs.hashes-mac }}

runs:
using: composite
Expand Down Expand Up @@ -183,9 +183,9 @@ runs:
- name: Hash Mac Build Artifacts for provenance
if: runner.os == 'macOS'
shell: bash
id: hash-macos
id: hash-mac
run: |
echo "hashes-macos=$(shasum -a 256 mac-clang-x64-static.zip mac-clang-x64-dynamic.zip | base64 -b 0)" >> "$GITHUB_OUTPUT"
echo "hashes-mac=$(shasum -a 256 mac-clang-x64-static.zip mac-clang-x64-dynamic.zip | base64 -b 0)" >> "$GITHUB_OUTPUT"
- name: Upload Mac Build Artifacts
if: runner.os == 'macOS'
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/manual-sdk-release-artifacts.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:
outputs:
hashes-linux: ${{ steps.release-sdk.outputs.hashes-linux }}
hashes-windows: ${{ steps.release-sdk.outputs.hashes-windows }}
hashes-macos: ${{ steps.release-sdk.outputs.hashes-macos }}
hashes-mac: ${{ steps.release-sdk.outputs.hashes-mac }}
steps:
- uses: actions/checkout@v3
with:
Expand All @@ -59,7 +59,7 @@ jobs:
strategy:
matrix:
# Generates a combined attestation for each platform
os: [ linux, windows, macos ]
os: [ linux, windows, mac ]
permissions:
actions: read
id-token: write
Expand All @@ -69,4 +69,4 @@ jobs:
base64-subjects: "${{ needs.release-sdk.outputs[format('hashes-{0}', matrix.os)] }}"
upload-assets: true
upload-tag-name: ${{ inputs.tag }}
provenance-name: ${{ format('{0}-multiple.intoto.jsonl', matrix.os) }}
provenance-name: ${{ format('{0}-multiple-provenance.intoto.jsonl', matrix.os) }}
6 changes: 3 additions & 3 deletions .github/workflows/release-please.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
outputs:
hashes-linux: ${{ steps.release-client.outputs.hashes-linux }}
hashes-windows: ${{ steps.release-client.outputs.hashes-windows }}
hashes-macos: ${{ steps.release-client.outputs.hashes-macos }}
hashes-mac: ${{ steps.release-client.outputs.hashes-mac }}
steps:
- uses: actions/checkout@v3
- id: release-client
Expand All @@ -47,7 +47,7 @@ jobs:
strategy:
matrix:
# Generates a combined attestation for each platform
os: [ linux, windows, macos ]
os: [ linux, windows, mac ]
permissions:
actions: read
id-token: write
Expand All @@ -57,4 +57,4 @@ jobs:
base64-subjects: "${{ needs.release-client.outputs[format('hashes-{0}', matrix.os)] }}"
upload-assets: true
upload-tag-name: ${{ needs.release-please.outputs.package-client-tag }}
provenance-name: ${{ format('{0}-multiple.intoto.jsonl', matrix.os) }}
provenance-name: ${{ format('{0}-multiple-provenance.intoto.jsonl', matrix.os) }}

0 comments on commit ac9f745

Please sign in to comment.