Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement basic in-memory store and change handling. #165

Merged
merged 40 commits into from
Jul 12, 2023
Merged

feat: Implement basic in-memory store and change handling. #165

merged 40 commits into from
Jul 12, 2023

Conversation

kinyoklion
Copy link
Member

@kinyoklion kinyoklion commented Jul 10, 2023 •
edited
Loading

feat: Move boost signal implementation to the internal library.

kinyoklion added 21 commits July 6, 2023 14:11
@kinyoklion
chore: Implement architecture diagram for data store.
95bab24
@kinyoklion
Updates types for get methods on IDataStore.
a4b2c8c
@kinyoklion
Update collection types.
d368988
@kinyoklion
Merge branch 'server-side' into rlamb/data-store-arch
48bfc55
@kinyoklion
feat: Implement basic store.
758e825
@kinyoklion
Overloads for upsert and add extra const qualifiers.
6914703
@kinyoklion
Merge branch 'rlamb/data-store-arch' of github.com:launchdarkly/cpp-s…
c74f508 
…dks-private into rlamb/data-store-arch
@kinyoklion
Merge branch 'rlamb/data-store-arch' into rlamb/basic-store-implement…
cd1ec6f 
…ation
@kinyoklion
Basic data store and data source update sink interfaces.
e82dc04
@kinyoklion
Start adding change notifier.
54499d6
@kinyoklion
Merge branch 'server-side' into rlamb/basic-store-implementation
1df05f9
@kinyoklion
Add empty implementation file.
5221784
@kinyoklion
Start adding memory store
e9734bc
@kinyoklion
Basic memory store functionaliy.
b53b004
@kinyoklion
Add memory store tests.
1d07b00
@kinyoklion
Add tests for dependency tracker.
58d284f
@kinyoklion
Split implementation and cleanup clang issues.
f6b9558
@kinyoklion
Refactoring and continue implementation of the data store updater.
d4a2a9d
@kinyoklion
Code cleanup and more tests.
091bcb8
@kinyoklion
Add a test for using an old value after upsert.
f3e0a5d
@kinyoklion
Merge branch 'server-side' into rlamb/basic-store-implementation
0bd9846
@kinyoklion kinyoklion changed the title chore: Implement architecture diagram for data store. feat: Implement basic in-memory store and change handling. Jul 10, 2023
@kinyoklion kinyoklion marked this pull request as ready for review July 10, 2023 22:51
@kinyoklion kinyoklion requested a review from a team July 10, 2023 22:51
@kinyoklion kinyoklion marked this pull request as draft July 11, 2023 16:00
@kinyoklion
Copy link
Member Author

kinyoklion commented Jul 11, 2023 •
edited
Loading

Converted to draft because I missed some testing and found a couple issues. Fixed.

@kinyoklion kinyoklion marked this pull request as ready for review July 11, 2023 16:19
cwaldren-ld
cwaldren-ld reviewed Jul 11, 2023
View reviewed changes
libs/server-sdk/src/data_store/data_store.hpp Outdated Show resolved Hide resolved
libs/server-sdk/src/data_store/data_store.hpp Outdated Show resolved Hide resolved
libs/server-sdk/src/data_store/data_store.hpp Outdated Show resolved Hide resolved
libs/server-sdk/src/data_store/data_store.hpp Outdated Show resolved Hide resolved
libs/server-sdk/src/data_store/data_store.hpp Outdated Show resolved Hide resolved
libs/server-sdk/src/data_store/dependency_tracker.cpp Outdated Show resolved Hide resolved
libs/server-sdk/src/data_store/dependency_tracker.cpp Outdated Show resolved Hide resolved
libs/server-sdk/src/data_store/dependency_tracker.cpp Outdated Show resolved Hide resolved
libs/server-sdk/src/data_store/dependency_tracker.hpp Show resolved Hide resolved
libs/server-sdk/src/data_store/dependency_tracker.hpp Outdated Show resolved Hide resolved
kinyoklion
kinyoklion commented Jul 11, 2023
View reviewed changes
libs/server-sdk/src/data_store/data_store_updater.hpp
sink_->Upsert(key, updated);
}

template <typename FlagOrSegment>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still FlagOrSegment, because DataKind is a type, which is also used by this same method. Which is inconvenient.

cwaldren-ld
cwaldren-ld approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@cwaldren-ld cwaldren-ld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple lints on libs/server-sdk/src/data_store/dependency_tracker.cpp seem legit, but otherwise looks good!

@kinyoklion kinyoklion merged commit f2d96a4 into server-side Jul 12, 2023
@kinyoklion kinyoklion deleted the rlamb/basic-store-implementation branch July 12, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwaldren-ld cwaldren-ld cwaldren-ld approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kinyoklion @cwaldren-ld