chore: resolve ValidChar function lint/compile warnings #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwaldren-ld
changed the title
cwaldren-ld
commented
Sep 5, 2023
| @@ -21,9 +21,9 @@ tl::expected<std::string, Error> AppInfoBuilder::Tag::Build() const { | |||
| } | |||
|
|
|||
| bool ValidChar(char c) { | |||
| if(c > 0 && c < 255) { | |||
There was a problem hiding this comment.
Could put a static_assert(std::numeric_limits<char>::max() <= 0xFF). Is that too paranoid?
kinyoklion
reviewed
Sep 5, 2023
| // The MSVC implementation of isalnum will assert if the number it outside | ||
| // its lookup table. | ||
| if (c > 0) { | ||
| // The MSVC implementation of isalnum will assert if the number it |
There was a problem hiding this comment.
I must have typoed this 'it'. Should be 'is'.
kinyoklion
reviewed
Sep 5, 2023
Co-authored-by: Ryan Lamb <4955475+kinyoklion@users.noreply.github.com>
kinyoklion
approved these changes
Sep 5, 2023
cwaldren-ld
added a commit
that referenced
this pull request
Sep 11, 2023
The argument to `ValidChar` is a `char`, so its max value is `255` rendering the check redundant. This causes a warning on our Mac compilations as well as a linter warning. --------- Co-authored-by: Ryan Lamb <4955475+kinyoklion@users.noreply.github.com>
cwaldren-ld
added a commit
that referenced
this pull request
Sep 11, 2023
The argument to `ValidChar` is a `char`, so its max value is `255` rendering the check redundant. This causes a warning on our Mac compilations as well as a linter warning. Co-authored-by: Ryan Lamb <4955475+kinyoklion@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The argument to
ValidCharis achar, so its max value is255rendering the check redundant. This causes a warning on our Mac compilations as well as a linter warning.(unless we have a platform that has a char wider than 8 bits..)