chore: remove server-side version from release-please manifest #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwaldren-ld
commented
Oct 24, 2023
| @@ -1,6 +1,5 @@ | |||
| { | |||
| "libs/client-sdk": "3.2.1", | |||
There was a problem hiding this comment.
Theory: release please will now:
(1) Not think that a release has been performed for 0.1.0 (which it hasn't) due to this change
(2) Will assign the next release number as 0.1.0 due to change in release-please-config.json:23
kinyoklion
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix the pending release.
Ideally, release please would detect that no release is necessary or that a 0.1.0 initial release of the server side only is necessary.
Right now, it thinks that the
sse-clientneeds a release, and it's therefore bumping that and the server/client SDKs.