chore: refactor openssl setup into dedicated x-platform action #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwaldren-ld
commented
Oct 27, 2023
| using: composite | ||
| steps: | ||
| # The ubuntu runner already has OpenSSL > 3 and CMake can find it. | ||
| - name: Install for Ubuntu. |
There was a problem hiding this comment.
The OpenSSL version on ubuntu 22.04 isn't going to go backwards (unless entropy in the universe reverses?), so I didn't do anything smart here. Maybe I assume too much.
cwaldren-ld
force-pushed
the
cw/refactor-openssl-setup-action
branch
from
72b17f8 to
24535ba
Compare
kinyoklion
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting up the correct OpenSSL version should be encapsulated in the
ciaction, but it leaked out when I added the code to ensure OpenSSL > 3 on all runners.Putting it back in its place. Motivated because I'm making another action that could use this.