fix: Remove vendored boost file to compile with boost 1.87. #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinyoklion
force-pushed
the
rlamb/remove-vendored-allocate_unique
branch
from
0b1cefa to
63a5c92
Compare
fix: Replace expires_from_now with expires_after.
kinyoklion
force-pushed
the
rlamb/remove-vendored-allocate_unique
branch
from
63a5c92 to
42cc871
Compare
kinyoklion
commented
Dec 20, 2024
| @@ -37,13 +37,13 @@ void EventOutbox::do_shutdown(beast::error_code ec) { | |||
| void EventOutbox::post_event(launchdarkly::sse::Event event) { | |||
| auto http_request = build_request(callback_counter_++, std::move(event)); | |||
| outbox_.push(http_request); | |||
| flush_timer_.expires_from_now(boost::posix_time::milliseconds(0)); | |||
There was a problem hiding this comment.
API has been deprecated. The new API already exists in the oldest boost we support.
kinyoklion
commented
Dec 20, 2024
| @@ -1,5 +1,3 @@ | |||
| #include <boost/json/system_error.hpp> | |||
There was a problem hiding this comment.
This import was not used, and has been removed.
kinyoklion
commented
Dec 20, 2024
There was a problem hiding this comment.
Appears to have been added to boost in 1.72, and the library at the time seems to have built with 1.71. So likely this was to allow working with boost 1.71 and still using this feature.
keelerm84
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
fix: Remove vendored boost file to compile with boost 1.87.
fix: Update usage of the steady_timer to be compatible with boost 1.87.
fix: Remove type alias import for JSON system_error that was removed in boost 1.87.
END_COMMIT_OVERRIDE