fix: Make gun open errors explicitly into temporary failures #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinyoklion
changed the title
kinyoklion
approved these changes
Jan 4, 2024
kinyoklion
pushed a commit
that referenced
this pull request
Jan 4, 2024
🤖 I have created a release *beep* *boop* --- ## [3.1.0](v3.0.4...v3.1.0) (2024-01-04) ### Features * For otp 25+ use public_key:cacerts_get for the default certificate list. ([#114](#114)) ([b7065aa](b7065aa)) ### Bug Fixes * Make gun open errors explicitly into temporary failures ([#118](#118)) ([fc70445](fc70445)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
gun_open_*failures during stream initialization to translate totemporaryfailures, as expected by the calling function.I think these errors were always meant to be explicitly
temporary. Otherwise, if these are currently returned the callingtryblock wouldn't pattern match and I believe it would crash the process. At that point we'd be relying on the supervisor restarts instead of managed backoff.