Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: bump tested Go versions to 1.24 and 1.23 #247

Merged
merged 2 commits into from
Feb 18, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/variables/go-versions.env
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
latest=1.23
penultimate=1.22
latest=1.24
penultimate=1.23
min=1.20
1 change: 0 additions & 1 deletion .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ linters:
- bodyclose
- dupl
- errcheck
- exportloopref
- goconst
- gochecknoglobals
- gochecknoinits
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
GOLANGCI_LINT_VERSION=v1.60.1
GOLANGCI_LINT_VERSION=v1.64.5

LINTER=./bin/golangci-lint
LINTER_VERSION_FILE=./bin/.golangci-lint-version-$(GOLANGCI_LINT_VERSION)
Expand Down
4 changes: 1 addition & 3 deletions internal/concurrent.go
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
package internal

import (
"sync/atomic"
)
import "sync/atomic"

// AtomicBoolean is a simple atomic boolean type based on sync/atomic. Since sync/atomic supports
// only integer types, the implementation uses an int32. (Note: we should be able to get rid of
Expand Down
2 changes: 1 addition & 1 deletion internal/endpoints/configure_endpoints.go
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ type ServiceType int
const (
StreamingService ServiceType = iota //nolint:revive // internal constant
PollingService ServiceType = iota //nolint:revive // internal constant
EventsService ServiceType = iota //nolint:revive // internal constant
EventsService ServiceType = iota // internal constant
)

func (s ServiceType) String() string {
Expand Down
2 changes: 1 addition & 1 deletion ldcomponents/send_events.go
Original file line number Diff line number Diff line change
Expand Up @@ -236,5 +236,5 @@ func (b *EventProcessorBuilder) DescribeConfiguration(context subsystems.ClientC
}

func durationToMillisValue(d time.Duration) ldvalue.Value {
return ldvalue.Float64(float64(uint64(d / time.Millisecond)))
return ldvalue.Float64(float64(uint64(d / time.Millisecond))) //nolint:gosec
}
2 changes: 1 addition & 1 deletion server_side_diagnostics.go
Original file line number Diff line number Diff line change
Expand Up @@ -105,5 +105,5 @@ func makeDiagnosticSDKData() ldvalue.Value {
}

func durationToMillis(d time.Duration) ldvalue.Value {
return ldvalue.Float64(float64(uint64(d / time.Millisecond)))
return ldvalue.Float64(float64(uint64(d / time.Millisecond))) //nolint:gosec
}
2 changes: 1 addition & 1 deletion subsystems/ldstoreimpl/big_segment_store_wrapper.go
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,7 @@ func (w *BigSegmentStoreWrapper) pollStoreAndUpdateStatus() interfaces.BigSegmen
}

func (w *BigSegmentStoreWrapper) isStale(updateTime ldtime.UnixMillisecondTime) bool {
age := time.Duration(uint64(ldtime.UnixMillisNow())-uint64(updateTime)) * time.Millisecond
age := time.Duration(uint64(ldtime.UnixMillisNow())-uint64(updateTime)) * time.Millisecond //nolint:gosec
return age >= w.staleTime
}

Expand Down
Loading