feat: Add option to omit anonymous users from index and identify events #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinyoklion
reviewed
Aug 23, 2024
src/LaunchDarkly/Server/Client.hs
Outdated
| _anyValidKey -> do | ||
| let identifyContext = optionallyRedactAnonymous (getField @"config" client) context | ||
| case identifyContext of | ||
| (Invalid err) -> clientRunLogger client $ $(logWarn) $ "identify called with an invalid context: " <> err |
There was a problem hiding this comment.
Are we going to log this whenever a single anonymous context is identified, or when a multi-context composed of only anonymous contexts is identified?
There was a problem hiding this comment.
Good point. This probably shouldn't log at all since it doesn't really matter.
kinyoklion
approved these changes
Aug 23, 2024
keelerm84
pushed a commit
that referenced
this pull request
Sep 5, 2024
🤖 I have created a release *beep* *boop* --- ## [4.2.0](4.1.0...4.2.0) (2024-08-23) ### Features * Add option to omit anonymous users from index and identify events ([#87](#87)) ([85e512a](85e512a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: LaunchDarklyReleaseBot <LaunchDarklyReleaseBot@launchdarkly.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.