prepare 2.19.3 release #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bw/fix broken readme links
refactor to isolate the sync XHR logic; expose close() method
add script to publish docs to Github Pages
fix uuid dependency, add unit tests for user key
change HTTP response handling to avoid CORS header errors
# Conflicts: # scripts/release-docs.sh # scripts/release.sh
don't use Promise.finally()
allow Electron and Node SDKs to report their own SDK version
…plates apply markdown templates
test code linting + fix lint step in CI
add inlineUsersToEvents to TypeScript defs by updating js-sdk-common
…-warning don't log a warning about custom goal being unknown
louis-launchdarkly
approved these changes
Oct 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[2.19.3] - 2021-10-12
Fixed:
track:Custom event "_____" does not exist. Originally, the SDK had an expectation thattrackwould be used only for event keys that had been previously defined as custom goals in the LaunchDarkly dashboard. That is still often the case, but it is not required and LaunchDarkly no longer sends custom goal names to the SDK, so the warning was happening even if such a goal did exist.