remove version constant which can't be exported from js-sdk-common (#…

…53)

.eslintrc.yaml

@@ -11,7 +11,6 @@ plugins:
   - babel
   - prettier
 globals:
-  VERSION: true
   describe: true
   it: true
   expect: true

jest.config.js

@@ -9,7 +9,4 @@ module.exports = {
   transform: {
     '^.+\\.js$': 'babel-jest',
   },
-  globals: {
-    VERSION: version,
-  },
 };

package.json

@@ -40,8 +40,6 @@
     "launchdarkly-js-test-helpers": "1.1.0",
     "prettier": "1.11.1",
     "readline-sync": "^1.4.9",
-    "semver": "^5.5.0",
-    "semver-compare": "^1.0.0",
     "typescript": "~4.4.4"
   },
   "dependencies": {

src/__tests__/.eslintrc.yaml

@@ -1,6 +1,5 @@
 ---
 globals:
-  VERSION: true
   sinon: true
   expect: true
   requestor: true

src/__tests__/LDClient-test.js

@@ -2,7 +2,6 @@ import * as LDClient from '../index';
 import * as messages from '../messages';
 import * as utils from '../utils';
 
-import semverCompare from 'semver-compare';
 import { eventSink, promisifySingle, sleepAsync, withCloseable, AsyncQueue } from 'launchdarkly-js-test-helpers';
 
 import { respond, respondJson } from './mockHttp';
@@ -106,13 +105,6 @@ describe('LDClient', () => {
       });
     });
 
-    it('should contain package version', () => {
-      const version = LDClient.version;
-      // All client bundles above 1.0.7 should contain package version
-      const result = semverCompare(version, '1.0.6');
-      expect(result).toEqual(1);
-    });
-
     async function verifyCustomHeader(sendLDHeaders, shouldGetHeaders) {
       await withServers(async (baseConfig, pollServer) => {
         await withClient(user, { ...baseConfig, sendLDHeaders }, async client => {

src/__tests__/utils-test.js

@@ -120,11 +120,11 @@ describe('utils', () => {
   });
 
   describe('getLDUserAgentString', () => {
-    it('uses platform user-agent and package version by default', () => {
+    it('uses platform user-agent and unknown version by default', () => {
       const platform = stubPlatform.defaults();
       platform.version = undefined;
       const ua = getLDUserAgentString(platform);
-      expect(ua).toEqual('stubClient/' + VERSION);
+      expect(ua).toEqual('stubClient/?');
     });
 
     it('uses platform user-agent and platform version if provided', () => {

src/index.js

@@ -760,13 +760,10 @@ function initialize(env, user, specifiedOptions, platform, extraOptionDefs) {
   };
 }
 
-const version = VERSION;
-
 module.exports = {
   initialize,
   commonBasicLogger,
   errors,
   messages,
   utils,
-  version,
 };

src/utils.js

@@ -146,7 +146,7 @@ function chunkUserEventsForUrl(maxLength, events) {
 }
 
 function getLDUserAgentString(platform) {
-  const version = platform.version || VERSION;
+  const version = platform.version || '?';
   return platform.userAgent + '/' + version;
 }
 

test-types.ts

@@ -4,8 +4,6 @@
 
 import * as ld from 'launchdarkly-js-sdk-common';
 
-var ver: string = ld.version;
-
 var userWithKeyOnly: ld.LDUser = { key: 'user' };
 var anonUserWithNoKey: ld.LDUser = { anonymous: true };
 var anonUserWithKey: ld.LDUser = { key: 'anon-user', anonymous: true };

typings.d.ts

@@ -2,12 +2,6 @@
  * Basic LaunchDarkly JavaScript client interfaces, shared between the browser SDK and the Electron SDK.
  */
 declare module 'launchdarkly-js-sdk-common' {
-
-  /**
-   * The current version string of the SDK.
-   */
-  export const version: string;
-
   /**
    * The types of values a feature flag can have.
    *