prepare 3.3.4 release (#51)

.circleci/config.yml

@@ -2,7 +2,7 @@ version: 2
 jobs:
   build:
     docker:
-      - image: circleci/node:11.10.1
+      - image: cimg/node:12.22
     steps:
       - checkout
 

.ldrelease/config.yml

@@ -1,3 +1,5 @@
+version: 2
+
 repo:
   public: js-sdk-common
   private: js-sdk-common-private
@@ -6,9 +8,12 @@ publications:
   - url: https://www.npmjs.com/package/launchdarkly-js-sdk-common
     description: npm
 
-template:
-  name: npm
+jobs:
+  - docker:
+      image: node:12-buster
+    template:
+      name: npm
 
 documentation:
-  githubPages: true
+  gitHubPages: true
   title: LaunchDarkly Javascript SDK Core Components

package.json

@@ -73,7 +73,7 @@
   "dependencies": {
     "base64-js": "^1.3.0",
     "fast-deep-equal": "^2.0.1",
-    "uuid": "^8.0.0"
+    "uuid": "^3.3.2"
   },
   "repository": {
     "type": "git",

src/EventSender.js

@@ -1,6 +1,6 @@
 import * as errors from './errors';
 import * as utils from './utils';
-const { v1: uuidv1 } = require('uuid');
+import uuidv1 from 'uuid/v1';
 
 const MAX_URL_LENGTH = 2000;
 

src/UserValidator.js

@@ -1,4 +1,4 @@
-const { v1: uuidv1 } = require('uuid');
+import uuidv1 from 'uuid/v1';
 
 import * as errors from './errors';
 import * as messages from './messages';

src/diagnosticEvents.js

@@ -1,4 +1,4 @@
-const { v1: uuidv1 } = require('uuid');
+const uuidv1 = require('uuid/v1');
 // Note that in the diagnostic events spec, these IDs are to be generated with UUID v4. However,
 // in JS we were already using v1 for unique user keys, so to avoid bringing in two packages we
 // will use v1 here as well.

src/index.js

@@ -341,6 +341,11 @@ export function initialize(env, user, specifiedOptions, platform, extraOptionDef
       return;
     }
 
+    // The following logic was used only for the JS browser SDK (js-client-sdk) and
+    // is no longer needed as of version 2.9.13 of that SDK. The other client-side
+    // JS-based SDKs did not define customEventFilter, and now none of them do. We
+    // can remove this in the next major version of the common code, when it's OK to
+    // make breaking changes to our internal API contracts.
     if (platform.customEventFilter && !platform.customEventFilter(key)) {
       logger.warn(messages.unknownCustomEventKey(key));
     }

src/messages.js

@@ -47,6 +47,7 @@ export const localStorageUnavailableForUserId = function() {
 
 export const networkError = e => 'network error' + (e ? ' (' + e + ')' : '');
 
+// We should remove unknownCustomEventKey in the future - see comments in track() in index.js
 export const unknownCustomEventKey = function(key) {
   return 'Custom event "' + key + '" does not exist';
 };