-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Linter #13
Add Linter #13
Conversation
reformat existing files add gradle commit check
This pull request has been linked to Shortcut Story #142420: [intellij] add kt linter. |
@@ -11,6 +11,7 @@ import com.launchdarkly.api.ApiException | |||
import com.launchdarkly.api.model.FeatureFlag | |||
import com.launchdarkly.api.model.FeatureFlags | |||
import com.launchdarkly.intellij.coderefs.FlagAliases | |||
/* ktlint-disable no-unused-imports */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added an upstream comment on an open issue: pinterest/ktlint#1277 (comment)
Without this disable line the import on line 15 will be removed.
.github/workflows/build.yml
Outdated
# Trigger the workflow on any pull request | ||
pull_request: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if i have indentation correct, but you may need to add this
# Trigger the workflow on any pull request | |
pull_request: | |
# Trigger the workflow on any pull request | |
pull_request: | |
types: [assigned, opened, synchronize, reopened] |
I locally installed https://plugins.jetbrains.com/plugin/7642-save-actions and set it up to format on save. I'm not sure if it's automatically picking up the tasks from this PR change or not, but it is automatically reformatting on save if it's not correct.