Add Linter #13
Closed
Add Linter #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reformat existing files add gradle commit check
|
This pull request has been linked to Shortcut Story #142420: [intellij] add kt linter. |
InTheCloudDan
commented
Feb 22, 2022
| @@ -11,6 +11,7 @@ import com.launchdarkly.api.ApiException | |||
| import com.launchdarkly.api.model.FeatureFlag | |||
| import com.launchdarkly.api.model.FeatureFlags | |||
| import com.launchdarkly.intellij.coderefs.FlagAliases | |||
| /* ktlint-disable no-unused-imports */ | |||
There was a problem hiding this comment.
Added an upstream comment on an open issue: pinterest/ktlint#1277 (comment)
Without this disable line the import on line 15 will be removed.
jazanne
reviewed
Feb 22, 2022
.github/workflows/build.yml
Outdated
Comment on lines
19
to
20
| # Trigger the workflow on any pull request | ||
| pull_request: |
There was a problem hiding this comment.
not sure if i have indentation correct, but you may need to add this
Suggested change
| # Trigger the workflow on any pull request | |
| pull_request: | |
| # Trigger the workflow on any pull request | |
| pull_request: | |
| types: [assigned, opened, synchronize, reopened] |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I locally installed https://plugins.jetbrains.com/plugin/7642-save-actions and set it up to format on save. I'm not sure if it's automatically picking up the tasks from this PR change or not, but it is automatically reformatting on save if it's not correct.