-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): bump C++ server dep for holdouts fix #109
Conversation
03544c2
to
d1cb7ca
Compare
9393f35
to
a9d45fc
Compare
For posterity: the hello-nginx example seems to be failing. Checked locally on my Mac, it works fine. But there is some oddness in the way it fails in CI. Ideally if the custom command fails, then our verify-hello-app action should log the issue and a message. But here we're just seeing "process failed with exit code 1". Wondering if the curl output itself is tripping up our verify-hello-app's template substitution of the command.
|
81ae959
to
d4c0539
Compare
0e3b43b
to
28e8bb7
Compare
@@ -39,20 +39,3 @@ COPY ./examples/env-helper/get_from_env_or_default.lua /usr/local/openresty/ngin | |||
|
|||
RUN luarocks make launchdarkly-server-sdk-"${VERSION}"-0.rockspec LD_DIR=./cpp-sdk-libs && \ | |||
cp launchdarkly_server_sdk.so /usr/local/openresty/lualib/ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This hack isn't needed, since we are building from source in this example.
🤖 I have created a release *beep* *boop* --- ## [2.1.2](v2.1.1...v2.1.2) (2024-11-18) ### Bug Fixes * **deps:** bump C++ server dep for holdouts fix ([#109](#109)) ([53a7ef1](53a7ef1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: LaunchDarklyReleaseBot <LaunchDarklyReleaseBot@launchdarkly.com>
This also switches to forks of the lua/luajit CI action, which have been forked into the
luarocks
org.The forks seem to be more up-to-date and are capable of fetching
luajit
, which is apparently not working with the old version of the action as LuaJIT is now distributed only via git.