Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): bump C++ server dep for holdouts fix #109

Merged
merged 21 commits into from
Nov 18, 2024

Conversation

cwaldren-ld
Copy link
Contributor

@cwaldren-ld cwaldren-ld commented Nov 15, 2024

This also switches to forks of the lua/luajit CI action, which have been forked into the luarocks org.

The forks seem to be more up-to-date and are capable of fetching luajit, which is apparently not working with the old version of the action as LuaJIT is now distributed only via git.

@cwaldren-ld cwaldren-ld requested a review from a team as a code owner November 15, 2024 00:12
@cwaldren-ld
Copy link
Contributor Author

cwaldren-ld commented Nov 15, 2024

For posterity: the hello-nginx example seems to be failing. Checked locally on my Mac, it works fine. But there is some oddness in the way it fails in CI.

Ideally if the custom command fails, then our verify-hello-app action should log the issue and a message. But here we're just seeing "process failed with exit code 1".

Wondering if the curl output itself is tripping up our verify-hello-app's template substitution of the command.

Run output=$(docker run -dit --rm --name hello-nginx -p 8123:80 \
*   Trying 127.0.0.1:8123...
* Connected to localhost (127.0.0.1) port 8123 (#0)
> GET / HTTP/1.1
> Host: localhost:8123
> User-Agent: curl/7.81.0
> Accept: */*
> 
* Mark bundle as not supporting multiuse
< HTTP/1.1 200 OK
< Server: openresty/1.27.1.1
< Date: Fri, 15 Nov 2024 00:42:06 GMT
< Content-Type: text/html
< Transfer-Encoding: chunked
< Connection: keep-alive
< 
{ [69 bytes data]
* Connection #0 to host localhost left intact
Error: Process completed with exit code 1.

@@ -39,20 +39,3 @@ COPY ./examples/env-helper/get_from_env_or_default.lua /usr/local/openresty/ngin

RUN luarocks make launchdarkly-server-sdk-"${VERSION}"-0.rockspec LD_DIR=./cpp-sdk-libs && \
cp launchdarkly_server_sdk.so /usr/local/openresty/lualib/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This hack isn't needed, since we are building from source in this example.

@cwaldren-ld cwaldren-ld merged commit 53a7ef1 into main Nov 18, 2024
14 checks passed
@cwaldren-ld cwaldren-ld deleted the cw/sdk-704-lua-holdouts branch November 18, 2024 23:12
cwaldren-ld pushed a commit that referenced this pull request Nov 18, 2024
🤖 I have created a release *beep* *boop*
---


##
[2.1.2](v2.1.1...v2.1.2)
(2024-11-18)


### Bug Fixes

* **deps:** bump C++ server dep for holdouts fix
([#109](#109))
([53a7ef1](53a7ef1))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: LaunchDarklyReleaseBot <LaunchDarklyReleaseBot@launchdarkly.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants