Fixes issue #19 - EventSource emits events out of order #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jkodumal @drichelson what do you guys think? |
|
This makes a lot of sense to me: pass the event in order, allow the receiver to choose whether to handle in single or multiple threads. |
|
I think this looks good-- we'll pull the branch into some upstream projects and do a little additional testing before merging and releasing. Thanks for the PR! |
drichelson
approved these changes
Apr 28, 2017
eli-darkly
added a commit
that referenced
this pull request
Dec 13, 2018
add interface for customizing requests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.