Fix usage of split_inclusive in event parser #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwaldren-ld
changed the title
cwaldren-ld
commented
Mar 24, 2022
It was relying on old behavior where Some(empty slice) would be returned if there were no matches. This was updated in more recent rust versions to return None, but CircleCI was using a much older version of rust than I have locally. Updated the usage and CircleCI config to use cimg/rust.
cwaldren-ld
force-pushed
the
cw/test-decode-line-split-across-chunks-failure-on-mac
branch
from
cf385b5 to
eda88f5
Compare
|
Final question on this. Are we enforcing a min-version that has the new behavior versus the old? |
cwaldren-ld
force-pushed
the
cw/test-decode-line-split-across-chunks-failure-on-mac
branch
from
2be2110 to
c746827
Compare
kinyoklion
approved these changes
Mar 30, 2022
cwaldren-ld
deleted the
cw/test-decode-line-split-across-chunks-failure-on-mac
branch
keelerm84
added a commit
that referenced
this pull request
Apr 11, 2022
This reverts commit 08a3496.
keelerm84
added a commit
that referenced
this pull request
Apr 11, 2022
This reverts commit d674a04.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
test-decode-line-split-across-chunksunit test failed locally on M1 Mac with a panic due tounwrap(). It was not failing in CircleCi.I then realized our CircleCi config was using the old rust image (
circleci/rust), so I updated tocimg/rust, whereupon the test began failing as it did locally.Due to rust-lang/rust#89825,
split_inclusivenow returnsNonewhen it used to returnSome(empty slice)in our event parser.The version of rust in
circleci/rustis Rust 1.49.0, which is before the issue I linked above.