fix: logify could panic if truncating mid-code point #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #226261: Fix logify panic in rust eventsource. |
kinyoklion
reviewed
Dec 7, 2023
| @@ -79,13 +79,9 @@ pub struct Event { | |||
| } | |||
|
|
|||
| const LOGIFY_MAX_CHARS: usize = 100; | |||
| fn logify(bytes: &[u8]) -> &str { | |||
| fn logify(bytes: &[u8]) -> String { | |||
There was a problem hiding this comment.
At the default logging level how often do we call this function?
There was a problem hiding this comment.
We only call this method for trace and debug, so it shouldn't be executed at all with a default logging configuration, I wouldn't think.
Wanting to drop this truncation functionality entirely?
There was a problem hiding this comment.
I was just checking that it wasn't all the time. I am down with this change.
There was a problem hiding this comment.
I do think we should consider an alternative longer term. (dropping it and doing it in a logger or something.)
kinyoklion
approved these changes
Dec 11, 2023
keelerm84
pushed a commit
that referenced
this pull request
Dec 12, 2023
🤖 I have created a release *beep* *boop* --- ## [0.12.1](0.12.0...0.12.1) (2023-12-12) ### Bug Fixes * logify could panic if truncating mid-code point ([#70](#70)) ([37316c4](37316c4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.