Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map additional fields for BigSegments. #187

Merged
merged 2 commits into from
Oct 16, 2023

Conversation

christogav
Copy link
Contributor

Map additional fields required for provider to support BigSegments.

  • Have you added comprehensive tests?
  • Have you updated relevant data sources as well as resources?
  • Have you updated the docs?

Testing

For any changes you make, please ensure your acceptance test conform to the following:

  • every single new attribute is tested
  • optional attributes revert to null or default values if removed
  • attributes that interact interact as expected
  • block values behave as expected when reordered
  • nested fields on maps or list/set items function as expected. Terraform does not actually enforce most schema attributes on nested items
  • each test step for a configuration is followed by a test step where ImportState and ImportStateVerify are set to true. ImportStateVerifyIgnore can be used if we explicitly expect a value to be different when imported, such as in the case of obfuscated values like API keys

LaunchDarkly Employees

For more information on how to build, test, and release, see the internal README on Confluence.

@ldhenry
Copy link
Collaborator

ldhenry commented Oct 13, 2023

Hey @christogav, thanks for your contribution! Our team will review it on Monday (sorry for the delay).

Copy link
Collaborator

@ldhenry ldhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! We'll need to make a few small internal changes to get this added to the Terraform provider's schema but we can take it from here. We'll try to get this released today.

@ldhenry ldhenry merged commit 3e5f75b into launchdarkly:main Oct 16, 2023
@ldhenry ldhenry mentioned this pull request Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants