Global refactoring adding type-hints, allow sf6 and php >=8 #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sadikoff
changed the title
|
Hey @laupiFrpar I hope you will have some time to review it =) Cheers and have a nice day! |
|
Strange. I canot see some tests results ! |
|
Hello, I am at hospital. And I don't have a computer. I use GitHub app and it is not simple to work with. As soon as I get home, I'll run the tests locally and merge as soon as it's ok. I get home next Tuesday. Best regards, |
|
woh man... Hope nothing is too serious and you will get better soon! Yeah tests are something complex, when you are moving to GH actions, they run only if master has a workflow file, and no tests are executed if workflow was just added in PR. Probably there is something that needs to be adjusted so no rush. just FYI |
|
Thank you I merge and I update the version to 6.0.0. Thank you again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I'd like to add a lot of changes to the lib. Unfortunately, there are so many changes so it will be a totally BC break. But let's move forward.
pusher/pusher-php-serverto the latestCheers!
closes #71