Skip to content

Commit

Permalink
Merge pull request docker#5291 from laurazard/fix-all-the-flaky-connh…
Browse files Browse the repository at this point in the history
…elper-tests

tests: fix other flaky `connhelper` tests
  • Loading branch information
laurazard authored Jul 24, 2024
2 parents 1055536 + 4a7388f commit 1e0f669
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions cli/connhelper/commandconn/commandconn_unix_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ func (mockStdoutEOF) Close() error {

func TestCloseWhileWriting(t *testing.T) {
ctx := context.TODO()
c, err := New(ctx, "sh", "-c", "while true; sleep 1; done")
c, err := New(ctx, "sh", "-c", "while true; do sleep 1; done")
assert.NilError(t, err)
cmdConn := c.(*commandConn)
assert.Check(t, process.Alive(cmdConn.cmd.Process.Pid))
Expand Down Expand Up @@ -173,7 +173,7 @@ func TestCloseWhileWriting(t *testing.T) {

func TestCloseWhileReading(t *testing.T) {
ctx := context.TODO()
c, err := New(ctx, "sh", "-c", "while true; sleep 1; done")
c, err := New(ctx, "sh", "-c", "while true; do sleep 1; done")
assert.NilError(t, err)
cmdConn := c.(*commandConn)
assert.Check(t, process.Alive(cmdConn.cmd.Process.Pid))
Expand Down

0 comments on commit 1e0f669

Please sign in to comment.