Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug Shift+Del wants to delete the note #10685

Closed
GigaTech opened this issue Jul 5, 2024 · 3 comments
Closed

Bug Shift+Del wants to delete the note #10685

GigaTech opened this issue Jul 5, 2024 · 3 comments
Labels
bug It's a bug desktop All desktop platforms high High priority issues

Comments

@GigaTech
Copy link

GigaTech commented Jul 5, 2024

Operating system

Windows

Joplin version

3.0.12

Desktop version info

Joplin 3.0.12 (prod, win32)

Client ID: 26c636c2b06d4d0395935193ad2eec1b
Sync Version: 3
Profile Version: 47
Keychain Supported: No

Revision: a64d6e3

Backup: 1.4.1
Email Note: 1.2.2

Current behaviour

I upgraded from 2.14.22 to 3.0.12, now Shift+Del tries to delete the note

Expected behaviour

Shift+Del should be 'cut', the same function as Ctrl+X which still works
Shift+Ins (same function as Ctrl+V) still works
Essential for left handed users

Logs

No response
@GigaTech GigaTech added the bug It's a bug label Jul 5, 2024
@personalizedrefrigerator
Copy link
Collaborator

A workaround might be to re-assign "permanently delete" from shift-delete to something else in Settings > "Keyboard Shortcuts", then restart Joplin.

screenshot: Permanently delete note is assigned to shift+delete in the keyboard shortcut tab in settings.

Notes:

  • Microsoft standard keyboard shortcut list includes shift-delete:
    • "Shift + Delete - Delete the selected item without moving it to the Recycle Bin first."
    • Presumably, this description is for File Explorer, and not for text editors. Perhaps this command/keyboard shortcut should only be enabled when the note list is selected?

@personalizedrefrigerator personalizedrefrigerator added desktop All desktop platforms high High priority issues labels Jul 5, 2024
@laurent22
Copy link
Owner

Perhaps this command/keyboard shortcut should only be enabled when the note list is selected?

Yes I guess it should only be enabled then. I see that there's no when clause like "noteListFocused" so maybe we could add one and make this a condition for "permanently delete note"

@GigaTech
Copy link
Author

GigaTech commented Jul 5, 2024

"only be enabled when the note list is selected" - perfect, when text is selected preform the equivalent of Ctrl+X and if note/To Do item or Notebook/folder is selected then perm delete. this is how windows and other apps work

Thanks

personalizedrefrigerator added a commit to personalizedrefrigerator/joplin that referenced this issue Jul 5, 2024
@personalizedrefrigerator
Desktop: Fixes laurent22#10685: Disable permanentlyDeleteNote command…
8c4aa7a 
… when the note list is not focused

This is one option for fixing laurent22#10685. It has a few drawbacks:
- Users might expect a cusom keyboard shortcut for permanentlyDeleteNote to be
  activatable when other parts of the app are focused.
- This disables the note > permanently delete note toolbar action when
  the note list doesn't have focus. Ideally, it would still be possible
  to permanently delete notes from this menu without first focusing the
  note list.
personalizedrefrigerator added a commit to personalizedrefrigerator/joplin that referenced this issue Jul 5, 2024
@personalizedrefrigerator
Desktop: Fixes laurent22#10685: Clear default keyboard shortcut for p…
caa0fa9 
…ermanentlyDeleteNote, activate it when pressing shift-delete and focusing the note list.

This commit is an alternate fix for laurent22#10685.

Comparison to 8c4aa7a:
- Benefit: It's possible to permanently delete the current note using
  Note > Permanently Delete Note, as before.
- Benefit: Shift-Delete still works, but only when the note list is
  focused.
- Benefit: It's possible to assign a custom keyboard shortcut to
  permanentlyDeleteNote that works regardless of what has focus.
- Drawback: The Shift-Delete default keyboard shortcut is now more
  difficult to discover -- it is no longer suggested by the Electron
  menu UI.
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug It's a bug desktop All desktop platforms high High priority issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@laurent22 @GigaTech @personalizedrefrigerator